Try to help fix https://github.com/Homebrew/homebrew-core/pull/67721#5
Try to help fix https://github.com/Homebrew/homebrew-core/pull/67721#5kit-ty-kate wants to merge 1 commit intochenrui333:bump-ocaml-4.10.2from
Conversation
|
Hello, @kit-ty-kate! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
| args = [] | ||
| args << "GIT_VERSION=#{version}" | ||
| system "opam", "config", "exec", "--", "make", *args | ||
| system "opam", "config", "exec", "--root=#{opam_dir}", "--", "make", *args |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| args = [] | ||
| args << "GIT_VERSION=#{version}" | ||
| system "opam", "config", "exec", "--", "make", *args | ||
| system "opam", "config", "exec", "--root=#{opam_dir}", "--", "make", *args |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| args = [] | ||
| args << "GIT_VERSION=#{version}" | ||
| system "opam", "config", "exec", "--", "make", *args | ||
| system "opam", "config", "exec", "--root=#{opam_dir}", "--", "make", *args |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| args = [] | ||
| args << "GIT_VERSION=#{version}" | ||
| system "opam", "config", "exec", "--", "make", *args | ||
| system "opam", "config", "exec", "--root=#{opam_dir}", "--", "make", *args |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| args = [] | ||
| args << "GIT_VERSION=#{version}" | ||
| system "opam", "config", "exec", "--", "make", *args | ||
| system "opam", "config", "exec", "--root=#{opam_dir}", "--", "make", *args |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| system "opam", "config", "exec", "--", | ||
| "opam", "install", "-y", "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", | ||
| system "opam", "install", "--root=#{opam_dir}", "-y", | ||
| "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| system "opam", "config", "exec", "--", | ||
| "opam", "install", "-y", "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", | ||
| system "opam", "install", "--root=#{opam_dir}", "-y", | ||
| "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| system "opam", "config", "exec", "--", | ||
| "opam", "install", "-y", "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", | ||
| system "opam", "install", "--root=#{opam_dir}", "-y", | ||
| "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| system "opam", "config", "exec", "--", | ||
| "opam", "install", "-y", "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", | ||
| system "opam", "install", "--root=#{opam_dir}", "-y", | ||
| "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
|
||
| system "opam", "config", "exec", "--", | ||
| "opam", "install", "-y", "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", | ||
| system "opam", "install", "--root=#{opam_dir}", "-y", |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
|
||
| system "opam", "config", "exec", "--", | ||
| "opam", "install", "-y", "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", | ||
| system "opam", "install", "--root=#{opam_dir}", "-y", |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
|
||
| system "opam", "config", "exec", "--", | ||
| "opam", "install", "-y", "uri.4.1.0", "qcow.0.11.0", "conduit.2.1.0", "lwt.5.3.0", | ||
| system "opam", "install", "--root=#{opam_dir}", "-y", |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| system "opam", "init", "--disable-sandboxing", "--no-setup" | ||
| opam_dir = "#{buildpath}/.brew_home/.opam" | ||
| opam_dir = "#{buildpath}/.opam" | ||
| system "opam", "init", "--disable-sandboxing", "--no-setup", "--root=#{opam_dir}" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| system "opam", "init", "--disable-sandboxing", "--no-setup" | ||
| opam_dir = "#{buildpath}/.brew_home/.opam" | ||
| opam_dir = "#{buildpath}/.opam" | ||
| system "opam", "init", "--disable-sandboxing", "--no-setup", "--root=#{opam_dir}" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| system "opam", "init", "--disable-sandboxing", "--no-setup" | ||
| opam_dir = "#{buildpath}/.brew_home/.opam" | ||
| opam_dir = "#{buildpath}/.opam" | ||
| system "opam", "init", "--disable-sandboxing", "--no-setup", "--root=#{opam_dir}" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| system "opam", "init", "--disable-sandboxing", "--no-setup" | ||
| opam_dir = "#{buildpath}/.brew_home/.opam" | ||
| opam_dir = "#{buildpath}/.opam" | ||
| system "opam", "init", "--disable-sandboxing", "--no-setup", "--root=#{opam_dir}" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
SourceLevel has finished reviewing this Pull Request and has found:
|
That's just a guess but in any case that sounds like a decent improvement anyway.