Changed CWs on replies to be kept if content is sensitive OR if there is spoiler text #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is spoiler text, rather than being only sensitive content and explicitly without spoiler text. Fixes cheeaun#1110.
cheeaun
requested changes
Aug 6, 2025
… there is already a content warning on the toot being replied to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Phanpy's logic around whether the Content Warning field in the UI should be pre-filled with the CW from a toot you're replying to be either if the
sensitiveflag is set or if there isspoiler_text(a CW). This is to work around behaviour from clients like Tusky that set thesensitiveflag back to false on replies with CWs when there isn't media attached.Fixes #1110 (I described my investigation into this problem in that issue).