Skip to content

Deprecate launch.groovy and merge functionality into diff.groovy #529

@rnveach

Description

@rnveach

Launch has outlived its purpose and should be deprecated as diff.groovy serves all our needs.

The only thing launch truthfully does now is no-error and no-exception testing. https://github.com/checkstyle/checkstyle/blob/master/.ci/no-exception-test.sh#L26-L27 . To support this, diff needs support to not-ignore the exclude paths as it is common to ignore java files that are only made for testing. Diff doesn't honor excludes by default.

#523 also needs to be done to merge that functionality.

This 2 should be the only functionalities needed to be merged into diff.groovy.

launch.groovy has to remain in repo until Checkstyle AND Sevntu is updated to remove all usage of it. Once Checkstyle AND Sevntu makes the conversion, then launch.groovy can be removed.

https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/LAUNCH_GROOVY_README.md should be removed when launch if finally removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions