Issue #8023: Add input file for Java14 records #8290
Issue #8023: Add input file for Java14 records #8290pbludov merged 1 commit intocheckstyle:masterfrom
Conversation
|
@nmancus1 , please keep CI happy all the time - https://travis-ci.org/github/checkstyle/checkstyle/jobs/693436338#L636 |
|
@nmancus1 , did you find any interesting examples in openjdk project ? |
What should I do in this case? Isn't this failing since we can't parse this file yet?
Yes, should I provide more examples? |
|
from travis: Checkstyle should not try to parse such files at all, we do not support non-compilable files at all, please investigate our config do not filter out such files.
if examples are different in some way - yes, |
We are still checking them with config |
|
Looks good to me once CI is green! |
|
@pbludov , @esilkensen , please do not allow commit message to start from issue, if it does not fix issue. in release notes it will looks like we provided support for this issue, but do not, and we just did some preparation fix for this issue. in such case you can do |
|
My bad. I didn't even look at the commit description. I'll keep it in mind for the future. |
Issue #8023: Add records input
Examples taken from:
https://blogs.oracle.com/javamagazine/records-come-to-java
https://alidg.me/blog/2020/2/9/java14-records-in-depth
https://openjdk.java.net/jeps/359
compilation is checked by:
checkstyle/.travis.yml
Lines 289 to 293 in 15ba4cc