Issue #4534: add ANNOTATION_DEF to defaultTokens to fix NPE#4535
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4535 +/- ##
======================================
Coverage 100% 100%
======================================
Files 285 285
Lines 15333 15333
Branches 3494 3494
======================================
Hits 15333 15333
Continue to review full report at Codecov.
|
rnveach
approved these changes
Jun 27, 2017
Contributor
|
@romani Shouldn't we look at regression? |
Member
Author
|
@rnveach, just planned to merge it sooner to avoid forcing all PR to rebase. Current implementation will not be very different even smth is found during testing. |
Contributor
|
@romani Here is regression http://rveach.no-ip.org/checkstyle/regression/reports/77/ . |
This was referenced Jun 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #4534
@rnveach , please review and merge if you agree.
regression could be provided later, we need to unblock wercker.