Skip to content

fix #33 : Allow to ignore java.lang and certain other classes#35

Closed
vmassol wants to merge 1 commit into
checkstyle:masterfrom
vmassol:issue-33
Closed

fix #33 : Allow to ignore java.lang and certain other classes#35
vmassol wants to merge 1 commit into
checkstyle:masterfrom
vmassol:issue-33

Conversation

@vmassol

@vmassol vmassol commented Oct 27, 2013

Copy link
Copy Markdown

No description provided.

@isopov

isopov commented Nov 2, 2013

Copy link
Copy Markdown
Contributor

Usually checkstyle allows users to completely override the default list. But since this particular list is large than usual - maybe this is valid option.

@romani

romani commented Nov 12, 2013

Copy link
Copy Markdown
Member

If pull request is not fixed in 7 fays, it is will be rejected.

@isopov

isopov commented Nov 17, 2013

Copy link
Copy Markdown
Contributor

This is minor change, but for some reason field, setter for it and getter for it are all named differently:

mUserIgnoredClassNames
getUserExcludedClasses()
setExcludedClasses

So I suggest to reject this PR and rewrite it with uniform naming for this configuration option.

@romani romani closed this Nov 18, 2013
@isopov isopov mentioned this pull request Nov 28, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmassol @isopov @romani