Issue #19905: Improve cached doc comments page rendering#19942
Conversation
|
GitHub, generate website |
|
|
| pre { | ||
| overflow-x: auto; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
please add an empty line at the end of the file
| pre { | ||
| overflow-x: auto; | ||
| } |
There was a problem hiding this comment.
because using this property the block of code gets a scrollbar, allowing horizontal scrolling. Instead of making the lines of code go to the next line
| pre { | ||
| overflow-x: auto; | ||
| } |
There was a problem hiding this comment.
we already have this property set outside of media query, we don't need to repeat it again here.
| h6 {font-size: 1.1em;} | ||
|
|
||
| main { | ||
| max-width: 1600px; |
There was a problem hiding this comment.
How does the text wrapping is working? I am assuming that you added max-width so the content can only expands maximum to 1600px, if the screen size is smaller then content adjusts itself to match the screen size.
This is just my assumptions, please correct me if I am wrong.
There was a problem hiding this comment.
Yes, this is just to make the appearance on desktop a bit better. Since I was adding css I thought of adding this too
|
Github, generate website |
|
Website looks good to me. @romani please review |
Issue #19905