Issue #19734: Added checks for OpenJDK Style §3.3.1 - Wildcard Imports by Anushreebasics · Pull Request #19735 · checkstyle/checkstyle

Anushreebasics · 2026-04-22T07:31:53Z

fixes #19734

Implements OpenJDK Style §3.3.1 (Wildcard Imports) for issue #19734.

This PR adds AvoidStarImport to OpenJDK config, updates OpenJDK style coverage docs, and adds integration tests for both regular and static wildcard imports.

Parent umbrella issue: #19604

Anushreebasics · 2026-04-22T08:00:43Z

@vivek-0509 please review

vivek-0509 · 2026-04-22T09:41:35Z

+
+import java.util.*; // violation '.*form of import should be avoided.*'
+import static java.lang.Math.*; // violation '.*form of import should be avoided.*'
+


Using the '.*' form of import should be avoided

use this as violation message and do not put .* at last, also do add more imports in this that are not star imports

vivek-0509 · 2026-04-22T09:42:49Z

+
+    @Test
+    public void avoidStarImportValidTest() throws Exception {
+        verifyWithWholeConfig(getPath("InputWildcardImportsValid.java"));
+    }


we do not need this, rather add valid imports in the same file which has star imports take reference from google style

Anushreebasics · 2026-04-22T15:36:46Z

@vivek-0509 please review

vivek-0509 · 2026-04-22T17:31:52Z

Github, generate website

github-actions · 2026-04-22T17:39:09Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2b6fdfb_20260422173833/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2b6fdfb_20260422173833/checks/imports/avoidstarimport.html#Example_of_Usage

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2b6fdfb_20260422173833/openjdk_style.html#Coverage_table

vivek-0509

LGTM
@romani Please take a look

romani

blocking this as start imports are allowed and Check need to be improved before used in this style guide

Anushreebasics · 2026-04-25T06:12:52Z

@vivek-0509 please review

Anushreebasics · 2026-04-26T12:51:55Z

@vivek-0509 please review

romani · 2026-04-28T12:55:41Z

as new property is required, lets do just new property at scope of #19496

and then add it style guide in scope of this PR.

I am blocking this PR until new property is added.

Aman-Baliyan · 2026-05-18T06:09:47Z

as new property is required, lets do just new property at scope of #19496

and then add it style guide in scope of this PR.

I am blocking this PR until new property is added.

@romani the new property is merged please remove the blocked label

romani · 2026-05-19T12:43:11Z

blocker label is removed.

@Anushreebasics , do you have time to finish update ?
it is ok to abandon PR, to let @Aman-Baliyan finish.

Anushreebasics · 2026-05-20T07:44:08Z

@romani thank you, I will finish it

Anushreebasics · 2026-05-31T14:37:09Z

@Aman-Baliyan pls review

Aman-Baliyan · 2026-05-31T15:45:08Z

Last one :

Plese fix this ci failure ->

ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 42.02 s <<< FAILURE! -- in com.puppycrawl.tools.checkstyle.internal.XdocsPagesTest
[ERROR] com.puppycrawl.tools.checkstyle.internal.XdocsPagesTest.testOpenJdkStyleRules -- Time elapsed: 0.039 s <<< FAILURE!
openjdk_style.xml rule 'Formatting' is missing sample link
expected to be false
	at com.puppycrawl.tools.checkstyle.internal.XdocsPagesTest.validateOpenJdkStyleSamples(XdocsPagesTest.java:2569)
	at com.puppycrawl.tools.checkstyle.internal.XdocsPagesTest.validateOpenJdkStyleModules(XdocsPagesTest.java:2533)
	at com.puppycrawl.tools.checkstyle.internal.XdocsPagesTest.testOpenJdkStyleRules(XdocsPagesTest.java:2461)

Aman-Baliyan · 2026-05-31T15:45:58Z

And make a single commit

Anushreebasics · 2026-05-31T16:06:41Z

@Aman-Baliyan pls review

Anushreebasics · 2026-06-01T06:48:38Z

@Aman-Baliyan pls review the changes

…ard Imports

Aman-Baliyan

Ready to merge

Aman-Baliyan · 2026-06-01T09:45:58Z

@romani ping

Aman-Baliyan · 2026-06-01T11:38:11Z

Github, generate site

github-actions · 2026-06-01T11:40:50Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2b0ebd9_20260601114010/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2b0ebd9_20260601114010/checks/imports/avoidstarimport.html#Example_of_Usage

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2b0ebd9_20260601114010/openjdk_style.html#Coverage_table

Anushreebasics · 2026-06-01T12:09:10Z

@Aman-Baliyan could you pls help me resolve this CI failure:
https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=42489&view=logs&j=23a36c3d-5ffa-5070-05d6-edc73e064208&t=e897831a-50c7-5d42-b05f-b6cc4fc690b4

Aman-Baliyan · 2026-06-01T12:22:50Z

@Aman-Baliyan could you pls help me resolve this CI failure: https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=42489&view=logs&j=23a36c3d-5ffa-5070-05d6-edc73e064208&t=e897831a-50c7-5d42-b05f-b6cc4fc690b4

this ci failure is not from your pr it is something else

Anushreebasics · 2026-06-04T16:08:59Z

@romani pls merge this PR

Aman-Baliyan · 2026-06-06T10:57:26Z

@romani ping

romani

thanks a lot

Anushreebasics force-pushed the 3.3.1 branch from 28c6222 to cb887f6 Compare April 22, 2026 07:42

vivek-0509 suggested changes Apr 22, 2026

View reviewed changes

Anushreebasics force-pushed the 3.3.1 branch 2 times, most recently from b5989f3 to 2b6fdfb Compare April 22, 2026 14:47

vivek-0509 approved these changes Apr 22, 2026

View reviewed changes

romani requested changes Apr 23, 2026

View reviewed changes

Anushreebasics force-pushed the 3.3.1 branch 11 times, most recently from 074cd5f to 96e0a33 Compare April 25, 2026 06:04

Anushreebasics force-pushed the 3.3.1 branch from 96e0a33 to c6c3d92 Compare April 25, 2026 06:31

romani added the blocked label Apr 28, 2026

romani removed the blocked label May 19, 2026

Aman-Baliyan reviewed May 27, 2026

View reviewed changes

Comment thread src/site/xdoc/openjdk_style.xml Outdated

Aman-Baliyan reviewed May 27, 2026

View reviewed changes

Comment thread ...k/checkstyle/test/chapter3formatting/rule331wildcardimports/InputWildcardImportsInvalid.java Outdated

Aman-Baliyan reviewed May 27, 2026

View reviewed changes

Comment thread ...k/checkstyle/test/chapter3formatting/rule331wildcardimports/InputWildcardImportsInvalid.java Outdated

Aman-Baliyan suggested changes May 27, 2026

View reviewed changes

Anushreebasics force-pushed the 3.3.1 branch 2 times, most recently from 9effe99 to d3e2395 Compare May 31, 2026 16:06

Aman-Baliyan suggested changes May 31, 2026

View reviewed changes

Comment thread src/site/xdoc/openjdk_style.xml Outdated

Anushreebasics force-pushed the 3.3.1 branch 2 times, most recently from b1ca21c to 4051606 Compare May 31, 2026 16:43

Anushreebasics requested a review from Aman-Baliyan May 31, 2026 16:44

Anushreebasics force-pushed the 3.3.1 branch from 4051606 to 2c37be6 Compare June 1, 2026 06:48

Anushreebasics force-pushed the 3.3.1 branch 2 times, most recently from f37c0c4 to c3b0a69 Compare June 1, 2026 09:12

Issue checkstyle#19734: Added checks for OpenJDK Style §3.3.1 - Wildc…

2b0ebd9

…ard Imports

Anushreebasics force-pushed the 3.3.1 branch from c3b0a69 to 2b0ebd9 Compare June 1, 2026 09:14

Aman-Baliyan approved these changes Jun 1, 2026

View reviewed changes

romani approved these changes Jun 7, 2026

View reviewed changes

romani merged commit ff3a849 into checkstyle:master Jun 7, 2026
125 of 128 checks passed


		import java.util.; // violation '.form of import should be avoided.*'
		import static java.lang.Math.; // violation '.form of import should be avoided.*'

Uh oh!

Conversation

Anushreebasics commented Apr 22, 2026

Uh oh!

Anushreebasics commented Apr 22, 2026

Uh oh!

vivek-0509 Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

vivek-0509 Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Anushreebasics commented Apr 22, 2026

Uh oh!

vivek-0509 commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

vivek-0509 left a comment

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Anushreebasics commented Apr 25, 2026

Uh oh!

Anushreebasics commented Apr 26, 2026

Uh oh!

romani commented Apr 28, 2026

Uh oh!

Aman-Baliyan commented May 18, 2026

Uh oh!

romani commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anushreebasics commented May 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Anushreebasics commented May 31, 2026

Uh oh!

Aman-Baliyan commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aman-Baliyan commented May 31, 2026

Uh oh!

Anushreebasics commented May 31, 2026

Uh oh!

Uh oh!

Anushreebasics commented Jun 1, 2026

Uh oh!

Aman-Baliyan left a comment

Choose a reason for hiding this comment

Uh oh!

Aman-Baliyan commented Jun 1, 2026

Uh oh!

Aman-Baliyan commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

Anushreebasics commented Jun 1, 2026

Uh oh!

Aman-Baliyan commented Jun 1, 2026

Uh oh!

Anushreebasics commented Jun 4, 2026

Uh oh!

Aman-Baliyan commented Jun 6, 2026

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

romani commented May 19, 2026 •

edited

Loading

Aman-Baliyan commented May 31, 2026 •

edited

Loading