Issue #14121: removed inner Handlers reference to Check itself#19704
Issue #14121: removed inner Handlers reference to Check itself#19704Anushreebasics wants to merge 1 commit into
Conversation
f967c02 to
d0bddbc
Compare
|
@smita1078 @romani please review |
|
@vivek-0509 , what do you think about this update? |
|
@romani As we discussed before the core problem in this issue that we need to solve is a cyclic dependency between Before we write a single line of code we need to agree on a proper solution for this, since it is a big refactoring work of the most complex check we have. @Anushreebasics if you are interested about solving this issue i would suggest you to understand the working of the indentation check then you can propose you solution and we can than discuss from there. you can also take reference from the discussion we had earlier here |
fixes #14121
The issue’s requirement was to remove handler dependence on public [IndentationCheck]helpers, and that has been done by making those helper methods package-private in [IndentationCheck.java]. I also updated the one cross-package test that was using the internal tab-width getter, and the focused indentation tests passed.