Issue #9070: add anchor links to option tables in property_types.xml#19678
Merged
romani merged 1 commit intoApr 12, 2026
Merged
Conversation
Collaborator
|
Github, generate site |
stoyanK7
suggested changes
Apr 11, 2026
Comment on lines
+217
to
+225
| <td> | ||
| <a name="BlockOption-text"/> | ||
| <a href="#BlockOption-text"> | ||
| <span class="wrapper inline"> | ||
| <img src="images/anchor.png" alt=""/> | ||
| </span> | ||
| </a> | ||
| <code>text</code> | ||
| </td> |
Collaborator
There was a problem hiding this comment.
Please see how we already put anchors. We use JS for that, not HTML: https://github.com/checkstyle/checkstyle/blob/master/src/site/resources/js/anchors.js
Member
There was a problem hiding this comment.
Let's do same as we did with properties of checks https://checkstyle.org/checks/annotation/annotationlocation.html#Properties
76392ad to
1f20915
Compare
1f20915 to
e04d4f6
Compare
Contributor
Author
|
Github, generate site |
Contributor
Author
stoyanK7
approved these changes
Apr 12, 2026
stoyanK7
left a comment
Collaborator
There was a problem hiding this comment.
Scrolled through the page. Looks good to me👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9070
added anchor links to all option table rows in property_types.xml, like used in google_style.xml.