Skip to content

Issue #19641: Add New OpenJDK Style 3.10 Variable Declaration Rule 1#19651

Merged
romani merged 1 commit into
checkstyle:masterfrom
lithops-zty:issue-19641-openjdk-rule-3.10.1
Apr 23, 2026
Merged

Issue #19641: Add New OpenJDK Style 3.10 Variable Declaration Rule 1#19651
romani merged 1 commit into
checkstyle:masterfrom
lithops-zty:issue-19641-openjdk-rule-3.10.1

Conversation

@lithops-zty

Copy link
Copy Markdown
Contributor

Part 1 of issue: #19641

Summary

  1. Add integration test for rule: one variable per declaration and one declaration per line.
  2. Update openjdk_style.xml
  3. Update config in openjdk_checks.xml
  4. Add reference to OpenJDK example usage in MultipleVariableDeclarations check page.

@vivek-0509

vivek-0509 commented Apr 8, 2026

Copy link
Copy Markdown
Member

@lithops-zty We need to follow the chapterwise format. Please see Google style for reference and rebase than convert your PR to follow that. We have recently merged this PR to support chapterwise testing for OpenJDK.

@lithops-zty lithops-zty force-pushed the issue-19641-openjdk-rule-3.10.1 branch from 8b677f0 to be85f87 Compare April 8, 2026 14:17
@lithops-zty

Copy link
Copy Markdown
Contributor Author

GitHub, generate website

@lithops-zty lithops-zty force-pushed the issue-19641-openjdk-rule-3.10.1 branch from be85f87 to 69f2d89 Compare April 21, 2026 12:13
@lithops-zty

Copy link
Copy Markdown
Contributor Author

@romani PR is ready for review.

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

@lithops-zty lithops-zty force-pushed the issue-19641-openjdk-rule-3.10.1 branch 2 times, most recently from eeb84a3 to a95fb16 Compare April 22, 2026 06:03
@lithops-zty lithops-zty force-pushed the issue-19641-openjdk-rule-3.10.1 branch from a95fb16 to 35897ff Compare April 23, 2026 01:39
@romani

romani commented Apr 23, 2026

Copy link
Copy Markdown
Member

please resolve conflcit

@romani

romani commented Apr 23, 2026

Copy link
Copy Markdown
Member

@lithops-zty , please do not resolve review items, let me resolve them, you can just reply "done" to confirm that it was addresed

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is good, thanks a lot.

@lithops-zty lithops-zty force-pushed the issue-19641-openjdk-rule-3.10.1 branch from 35897ff to 683d2b7 Compare April 23, 2026 13:05
@lithops-zty

Copy link
Copy Markdown
Contributor Author

@romani Understand. I will refrain from resolving items in the future.
Conflicts resolved.

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@romani romani merged commit 90985ad into checkstyle:master Apr 23, 2026
120 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants