Issue #19623: ImportOrder 3.3's Rule 1 update#19628
Merged
Merged
Conversation
Contributor
Author
|
ci failure unrelated |
Member
Member
|
@aclfe Please fix the ci |
Contributor
Author
Will do @vivek-0509 |
Member
|
@aclfe , do you have time to finish this PR ? |
Contributor
Author
|
Please review changes, thanks for being patient team! Pitest imports is a network error, needs a rerun |
romani
approved these changes
May 13, 2026
romani
left a comment
Member
There was a problem hiding this comment.
merging as good starting point for chapter , but config needs to be improved
|
|
||
| <!-- §3.3: Import statements should be sorted --> | ||
| <module name="ImportOrder"> | ||
| <property name="groups" value="java,javax"/> |
Member
There was a problem hiding this comment.
there should be org and com packages, as it is shown in style guide as example.
We need analyse jdk source that get more details what is list of internal and external packages means.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #19623: ImportOrder 3.3's Rule 1 update
Updating documentation and adding test files.