Skip to content

Issue #14084: Remove nullness suppression in WhenShouldBeUsedCheck#19583

Merged
romani merged 1 commit into
checkstyle:masterfrom
Carbon14-48:14084-nullness-whenshouldbeused
Apr 5, 2026
Merged

Issue #14084: Remove nullness suppression in WhenShouldBeUsedCheck#19583
romani merged 1 commit into
checkstyle:masterfrom
Carbon14-48:14084-nullness-whenshouldbeused

Conversation

@Carbon14-48

Copy link
Copy Markdown
Contributor

issue : #14084

refactored getStatementList() in WhenShouldBeUsedCheck to return Optional<DetailAST> instead of nullable DetailAST

@Carbon14-48 Carbon14-48 force-pushed the 14084-nullness-whenshouldbeused branch 2 times, most recently from 5fa9c88 to 68c2847 Compare April 3, 2026 19:43
@Carbon14-48

Carbon14-48 commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

wow everything failed :(

edit :ci failure arent related it seems there is a probelm installing groovy

@Carbon14-48 Carbon14-48 force-pushed the 14084-nullness-whenshouldbeused branch from 68c2847 to ea6247a Compare April 3, 2026 20:55
@romani

romani commented Apr 4, 2026

Copy link
Copy Markdown
Member

Checker restarted

@Carbon14-48 Carbon14-48 force-pushed the 14084-nullness-whenshouldbeused branch from ea6247a to 468fd44 Compare April 4, 2026 00:35
@Carbon14-48

Copy link
Copy Markdown
Contributor Author

Checker restarted

thanks for restarting ! but it still fails :( curl ... get.sdkman.io | bash\ is what's causing it

@Carbon14-48 Carbon14-48 force-pushed the 14084-nullness-whenshouldbeused branch from 468fd44 to 0bb27bf Compare April 4, 2026 15:05

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@romani romani merged commit 4a376da into checkstyle:master Apr 5, 2026
122 of 123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants