Issue #19525: Fix pitest mutations in SuppressionsLoader#19531
Merged
romani merged 1 commit intoMar 30, 2026
Merged
Conversation
defaca9 to
f767ac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #19525
Problem:
8 pitest mutations in SuppressionsLoader were surviving. Tests only checked if filter count was 1, but didn't verify which DTD was loaded. When a map.put() was mutated, the parser fell back to fetching the DTD from a network URL, making tests pass incorrectly.
Fix:
Changed the 4 XML test files to use a non-existent DTD url. Now when a map.put() mutation removes the local DTD mapping, the parser has no valid fallback and the test fails, properly killing the mutation. Removed all 8 suppressions.