Issue #19515: install xmlstarlet if not present in versions validation#19521
Merged
romani merged 1 commit intoMar 30, 2026
Merged
Conversation
romani
requested changes
Mar 29, 2026
|
|
||
| versions) | ||
| if ! command -v xmlstarlet &> /dev/null; then | ||
| sudo apt-get install -y xmlstarlet |
Member
There was a problem hiding this comment.
please add this to CI config to be be done before job execution.
all tasks in validation.sh expects that all tools are installed already.
a0a4638 to
c40a14a
Compare
romani
requested changes
Mar 30, 2026
| 'versions': | ||
| image: 'ubuntu-24.04' | ||
| cmd: "./.ci/validation.sh versions" | ||
| cmd: "sudo apt-get install -y xmlstarlet && ./.ci/validation.sh versions" |
Member
There was a problem hiding this comment.
0331e6a to
88849ec
Compare
88849ec to
82602f2
Compare
Contributor
Author
|
@romani unrelated fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19515
moved xmlstarlet installation to azure-pipelines.yml as a pre-step before job execution, since all tasks in validation.sh expect tools to be already installed.