Issue #12721: add Buildkite CI with mvn verify#19427
Conversation
|
@romani unrelated fail here, please let me know if any other change needed |
| - label: ":maven: verify" | ||
| command: | ||
| - "apt-get update && apt-get install -y libxext6 libxrender1 libxtst6 libxi6 xvfb" | ||
| - "mvn -e --no-transfer-progress verify -Dsurefire.excludes=**/MainTest.java" |
There was a problem hiding this comment.
-Dsurefire.excludes=**/MainTest.java why is it required ?
There was a problem hiding this comment.
actually yes, it is not needed for a basic verify run, I'll remove it
43db125 to
fd6ae46
Compare
|
@romani updated , let me know if any other change needed |
fd6ae46 to
10989e0
Compare
romani
left a comment
There was a problem hiding this comment.
Do you have example how it integrates to PR? Is it visible list of CIs?
| steps: | ||
| - label: ":maven: verify" | ||
| command: | ||
| - "apt-get update && apt-get install -y libxext6 libxrender1 libxtst6 libxi6 xvfb" |
There was a problem hiding this comment.
Why all such libraries are required?
Non of CI needs them, look strange
There was a problem hiding this comment.
during local testing i got display related error and adding them fixed it, let me check it out locally, I'll update here shortly
10989e0 to
67de463
Compare
|
@romani check it locally, those lib were from other env issue locally, not for this build, those are removed now |
|
@romani also regarding your other concern , yes, i set up a buildkite account and connected it to my forked repo to test this. my build here already ran successfully on our issue. ig for it to appear in pr check list buildkite would be need to be connect to main checktyle repo, then it may report check directly on prs |
|
Is there way to run two jobs in parallel? We try to keep CI as confirmation of environment, and all details on special commands are in validation.sh to be easily reused and run same on local. |
|
They allow 3 concurrent jobs in personnel plan. We will see how it works, and how credits are used |
|
All maven jobs needs cache of .m2 folder where all jar are stored, it speeds up building time dramatically. How can we reuse it? All other CI do have cache. |
67de463 to
14a2157
Compare
14a2157 to
cf55976
Compare
|
@romani updated - > also tested on fork - 3 jobs ran in parallel. |
|
Can you share link to build to let me confirm. By config it looks like sequential execution. |
|
@romani yes they run in parallel, the link - https://buildkite.com/ayush-singh/checkstyle-verify/builds/47 you may have to login to view it, also if there is an issue do let me know, still here's a ss of the same for reference - |
romani
left a comment
There was a problem hiding this comment.
Big event, new CI in our pipeline.
Thanks a lot
Closes #12721
added Buildkite ci pipeline config to run
mvn verifyon every push and pull request.