Issue #15484: UnusedTryResourceShouldBeUnnamed module#19359
Conversation
4e93342 to
d6bccfd
Compare
|
since you are implementing new module, please provide proper configuration like this in PR description like this #19039 and |
I'll address the CI first before running the diff report |
7f4bc2d to
bae1908
Compare
|
Github, generate report |
|
Report generation failed on phase "make_report", |
|
The check is finished and ready for reviewing. But issue preventing diff reports from executing |
|
look like 3.x tag is not exist in the RxJava repository. we have to change the tag in below file. |
|
Github, generate report |
|
@aclfe , please rebase and resovle conflict |
e7095a5 to
6757b2c
Compare
|
Very red CI |
|
Test failure, I'll address it |
f394d74 to
9dd5064
Compare
|
Github, generate report |
romani
left a comment
There was a problem hiding this comment.
same for all Input files of this PR:
ec4bae7 to
41b1a21
Compare
|
@aclfe , last item to be done, see above. |
41b1a21 to
c518aa1
Compare
Issue #15484: UnusedTryResourceShouldBeUnnamed module
Addressing all the false positives and other issues in the check preserving original intent
Contribution pr: checkstyle/contribution#1052
New module config: https://raw.githubusercontent.com/aclfe/configs/refs/heads/main/UnusedTryResourceShouldBeUnnamed.xml