Skip to content

Issue #15484: UnusedTryResourceShouldBeUnnamed module#19359

Merged
romani merged 1 commit into
checkstyle:masterfrom
aclfe:UnusedTryResourceShouldBeUnnamed
May 19, 2026
Merged

Issue #15484: UnusedTryResourceShouldBeUnnamed module#19359
romani merged 1 commit into
checkstyle:masterfrom
aclfe:UnusedTryResourceShouldBeUnnamed

Conversation

@aclfe

@aclfe aclfe commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Issue #15484: UnusedTryResourceShouldBeUnnamed module

Addressing all the false positives and other issues in the check preserving original intent

Contribution pr: checkstyle/contribution#1052

New module config: https://raw.githubusercontent.com/aclfe/configs/refs/heads/main/UnusedTryResourceShouldBeUnnamed.xml

@aclfe aclfe force-pushed the UnusedTryResourceShouldBeUnnamed branch from 4e93342 to d6bccfd Compare March 20, 2026 20:18
@Praveen7294

Praveen7294 commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

since you are implementing new module, please provide proper configuration like this in PR description like this #19039 and
https://gist.githubusercontent.com/Praveen7294/c6fd73abb4cfc532c5f9f14822d3ca58/raw/da5c048293c4009580a506bb41ca00e8dea77aab/config.xml

@aclfe

aclfe commented Mar 21, 2026

Copy link
Copy Markdown
Contributor Author

since you are implementing new module, please provide proper configuration like this in PR description like this #19039 and
https://gist.githubusercontent.com/Praveen7294/c6fd73abb4cfc532c5f9f14822d3ca58/raw/da5c048293c4009580a506bb41ca00e8dea77aab/config.xml

I'll address the CI first before running the diff report

@aclfe aclfe force-pushed the UnusedTryResourceShouldBeUnnamed branch 5 times, most recently from 7f4bc2d to bae1908 Compare March 21, 2026 17:46
@aclfe

aclfe commented Mar 21, 2026

Copy link
Copy Markdown
Contributor Author

Github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/23386234614

@aclfe

aclfe commented Mar 21, 2026

Copy link
Copy Markdown
Contributor Author

@romani

The check is finished and ready for reviewing. But issue preventing diff reports from executing

Running command: git fetch origin 3.x:3.x
From https://github.com/ReactiveX/RxJava
 * [new branch]          3.x        -> 3.x
Resetting git sources to commit '3.x'
Running command: git reset --hard refs/tags/3.x
fatal: ambiguous argument 'refs/tags/3.x': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Caught: groovy.lang.GroovyRuntimeException: Error: !
groovy.lang.GroovyRuntimeException: Error: !

@Praveen7294

Praveen7294 commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

@aclfe @romani

look like 3.x tag is not exist in the RxJava repository. we have to change the tag in below file.
https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/projects-to-test-on-for-github-action.properties

@aclfe

aclfe commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

Github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

@romani

romani commented May 13, 2026

Copy link
Copy Markdown
Member

@aclfe , please rebase and resovle conflict

@aclfe aclfe force-pushed the UnusedTryResourceShouldBeUnnamed branch 2 times, most recently from e7095a5 to 6757b2c Compare May 15, 2026 13:29
@romani

romani commented May 15, 2026

Copy link
Copy Markdown
Member

Very red CI

@aclfe

aclfe commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Test failure, I'll address it

@aclfe aclfe force-pushed the UnusedTryResourceShouldBeUnnamed branch 3 times, most recently from f394d74 to 9dd5064 Compare May 15, 2026 17:16
@romani

romani commented May 16, 2026

Copy link
Copy Markdown
Member

Github, generate report

@github-actions

Copy link
Copy Markdown
Contributor

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for all Input files of this PR:

Comment thread config/suppressions.xml Outdated
@aclfe aclfe force-pushed the UnusedTryResourceShouldBeUnnamed branch 3 times, most recently from ec4bae7 to 41b1a21 Compare May 17, 2026 08:12
@romani

romani commented May 17, 2026

Copy link
Copy Markdown
Member

@aclfe , last item to be done, see above.

@aclfe aclfe force-pushed the UnusedTryResourceShouldBeUnnamed branch from 41b1a21 to c518aa1 Compare May 19, 2026 07:28

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot !!!

@romani romani merged commit 667bfec into checkstyle:master May 19, 2026
128 checks passed
@aclfe aclfe deleted the UnusedTryResourceShouldBeUnnamed branch May 19, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants