Issue #4997: Column number in DetailAST should start with 1#19280
Open
ayushactiveat wants to merge 1 commit intocheckstyle:masterfrom
Open
Issue #4997: Column number in DetailAST should start with 1#19280ayushactiveat wants to merge 1 commit intocheckstyle:masterfrom
ayushactiveat wants to merge 1 commit intocheckstyle:masterfrom
Conversation
503b351 to
32de9de
Compare
Contributor
Author
|
hi @romani , ci fails seems unrelated, please let me know if u need any change |
629f784 to
95893af
Compare
95893af to
3c33f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4997
column numbers in
DetailASTpreviously started at 0 , with a workaround inAbstractCheck.log()that added+1 before reporting violations, this was inconsistent with most modern ides/editor display col no. (1-based).