Issue #19234: Resolving Circle CI failures #19239
Conversation
a911228 to
b43da89
Compare
romani
left a comment
There was a problem hiding this comment.
Thanks a lot, nice catch.
Items to improve:
| mkdir -p .ci-temp/spotbugs-and-pmd | ||
| CHECKSTYLE_DIR=$(pwd) | ||
| export MAVEN_OPTS='-Xmx2g' | ||
| export MAVEN_OPTS='-Xmx6g' |
There was a problem hiding this comment.
Can we try 3 or 4g ?
Jump from 2 to 6 is crazy.
| - validate-with-maven-script: | ||
| name: no-error-pmd | ||
| image-name: *cs_img | ||
| resource_class: large |
| resource_class: large | ||
| command: | | ||
| export MAVEN_OPTS="-Xmx6g -XX:MaxRAMPercentage=75" | ||
| ./.ci/validation.sh no-error-pmd |
There was a problem hiding this comment.
Please move all opts variables inside shell script.
|
Please enable job at place it was commented out. And please restore sonarqube commented block. |
I'll make all the changes |
66feade to
6105a0b
Compare
|
Ci failure in circle CI jobs is happening due to the recent check merged: |
|
please rebase, I merged new modules 1 hour ago. |
| ;; | ||
|
|
||
| no-error-pmd) | ||
| export MAVEN_OPTS="-XX:MaxRAMPercentage=75" |
There was a problem hiding this comment.
will it help if we make 90% and stay on smaller ci instances ?
we do not run anything else on CI boxes, so 10% from 4GB, might be ok for linux kernel to run.
There was a problem hiding this comment.
I don't think it should be making a huge difference. before the hard coded memory of 6 gigs was working wonders, but that's not a good approach long term
There was a problem hiding this comment.
but that was only because we put large as the resource class
4821177 to
3dfc43f
Compare
|
please apply spelling patch |
romani
left a comment
There was a problem hiding this comment.
will merge with pleasure, after CI pass
I pushed the whitelist words. no-error-pgjdbc in particular is very flaky, but with the current settings it's stably green continuously so it should be addressed for a while |
|
we will merge this awesome update, and will followup if required or some becomes annoying flacky. |
Issue #19234: Resolving Circle CI failures