Issue #19176: migrate metrics tests to getExpectedThrowable#19215
Merged
romani merged 1 commit intoMar 15, 2026
Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
|
conflict |
b130186 to
af70ed1
Compare
af70ed1 to
5d2c05c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #19176: migrate coding tests to getExpectedThrowable
Migrated 3 test files in the checks/metrics package from the old
assertWithMessage(...).fail() try-catch pattern to the new
getExpectedThrowable utility method.
Files migrated:
Also updated config/suppressions.xml to add checks/metrics to the
MatchXpathForbidTryCatchFail exclusion regex, and removed redundant
throws Exception from methods that no longer throw checked exceptions.
Resolves #19176
