Skip to content

Issue #19064: Validation of number of test in xdocs#19074

Merged
romani merged 1 commit into
checkstyle:masterfrom
Aman-Baliyan:xdoc
Mar 1, 2026
Merged

Issue #19064: Validation of number of test in xdocs#19074
romani merged 1 commit into
checkstyle:masterfrom
Aman-Baliyan:xdoc

Conversation

@Aman-Baliyan

Copy link
Copy Markdown
Contributor

Issue: #19064

This pr validate the number of test in XpathRegressionXxxxxxXxxxxxxTest should be atleast 3 there is a test already present in
checkstyle-non-main-files-checks.xml i increased it min value to 3 and then add the files in checkstyle-non-main-files-suppressions.xml which conatins less then 3 tests.

@Aman-Baliyan

Aman-Baliyan commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

is there a need of separate unit test for this?

@romani

romani commented Mar 1, 2026

Copy link
Copy Markdown
Member

Omg , we already have a Check :)

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@romani romani merged commit 4fdd0fc into checkstyle:master Mar 1, 2026
121 of 123 checks passed
@Aman-Baliyan Aman-Baliyan deleted the xdoc branch March 23, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants