Issue #18926: Re-enable 'EmptyClass' inspection by avadhutmali · Pull Request #19029 · checkstyle/checkstyle

avadhutmali · 2026-02-25T19:02:12Z

This PR re-enables the EmptyClass inspection in Qodana.

Note to reviewers: I am opening this PR as a draft initially to trigger the Qodana CI pipeline and filter the exact list of files violating this specific inspection. I will push the code fixes shortly once the CI provides the targeted report.

avadhutmali · 2026-02-25T21:57:32Z

@romani
I re-enabled the EmptyClass inspection. There are 0 actual violations in the codebase.
However, Qodana flags one false positive in JavadocCommentsTokenTypes.java at line 1804:

```
{@code * {@snippet :config}}
```

IntelliJ/Qodana evaluates the injected {@snippet} tag as a standalone file, which triggers the EmptyClass error. Since standard @SuppressWarnings is blocked by Checkstyle, and @noinspection is ignored by Qodana's isolated snippet parser, what is the preferred way to suppress this false positive?

romani

Items

romani · 2026-02-26T02:36:36Z

     * }</pre>
     *
+     * @noinspection EmptyClass
+     * @noinspectionreason EmptyClass - false positive from Language Injection in snippet block


Try to add to allowed suppressions for idea

checkstyle/config/intellij-idea-inspections.xml

Line 4436 in bdbc3c9

<option name="myAllowedSuppressions">

Suppression on field is not working.
Try to put suppression javadoc tags to class, not a field.

Please reproduce this problem in Idea on your local and ask Idea to suppress by annotation, and add javadoc tags to same element.

I opened the file in IntelliJ IDEA locally and reproduced the false positive — the {@snippet} injected block inside the COLON field javadoc is flagged as EmptyClass due to Language Injection. IntelliJ's "Suppress for class" quick-fix generated @SuppressWarnings("EmptyClass") and the matching @noinspection javadoc tags on the class element. However, IntelliJ's auto-formatter kept introducing formatting violations against checkstyle's strict rules, so I applied the changes manually in VS Code, mirroring exactly what IntelliJ's quick-fix produced. Also added EmptyClass to myAllowedSuppressions in intellij-idea-inspections.xml.

romani · 2026-02-26T04:36:00Z

https://checkstyle.org/idea.html#Inspections

Please reproduce it on local.

romani · 2026-03-08T14:40:46Z

We need green CI to merge, only circleci failure is known instability .

https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/53603210/job/5l406iy3qwa512sn#L100

[ERROR] [checkstyle] [ERROR] C:\projects\checkstyle\src\main\java\com\puppycrawl\tools\checkstyle\api\JavadocCommentsTokenTypes.java:1826: Trailing whitespace is not allowed [noTrailingWhitespace]

Copilot

Pull request overview

This PR re-enables the EmptyClass inspection in Qodana (issue #18926) by updating the IntelliJ IDEA inspection configuration and suppressing the inspection on a class that triggers a false positive.

Changes:

Re-enables the EmptyClass (and Java9ReflectionClassVisibility) inspection in the IntelliJ IDEA inspections config.
Adds EmptyClass to a suppression list for a specific inspection tool in the config.
Suppresses the EmptyClass inspection on JavadocCommentsTokenTypes.java with a documented reason.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`config/intellij-idea-inspections.xml`	Re-enables `EmptyClass` and `Java9ReflectionClassVisibility` inspections; adds `EmptyClass` to an exclusion list for a specific tool
`src/main/java/com/puppycrawl/tools/checkstyle/api/JavadocCommentsTokenTypes.java`	Suppresses the `EmptyClass` inspection on the class with a false-positive reason

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-08T16:15:02Z

@@ -1682,7 +1682,7 @@
  <inspection_tool class="EmptyCatchBlockJS" enabled="true" level="ERROR"
                   enabled_by_default="true"/>
  <!-- temporary disabled until https://github.com/checkstyle/checkstyle/issues/18926 -->


The comment on line 1684 ("temporary disabled until ...") was not removed when the inspection was re-enabled. Since this inspection is now enabled and the issue is resolved, the stale comment should be removed.

Suggested change

avadhutmali · 2026-03-08T16:47:59Z

@romani , I am still working on fixing the remaining CI failures. Will update the PR once all checks are green. Thank you for your patience. I will ping u when it complete from my side

romani · 2026-03-09T22:13:11Z

@avadhutmali, this is last fix for this issue, please find time to fix it sooner

avadhutmali · 2026-03-10T07:32:16Z

We need green CI to merge, only circleci failure is known instability .

@romani , Ping

romani

Last

romani · 2026-03-10T12:28:36Z

 *     javadoc - The Java API Documentation Generator</a>
- * @noinspection JavadocDeclaration
+ * @noinspection JavadocDeclaration ,EmptyClass
 * @noinspectionreason JavadocDeclaration - Javadoc is intentional


Please add new line for new noinspectionreason to explain reason we do suppression

romani

Thanks a lot

avadhutmali force-pushed the issue-18926-empty-class branch 4 times, most recently from 8a83f60 to b9c97c0 Compare February 25, 2026 21:39

romani requested changes Feb 26, 2026

View reviewed changes

avadhutmali force-pushed the issue-18926-empty-class branch 3 times, most recently from 5ff12bc to e73e2f4 Compare February 26, 2026 04:05

avadhutmali force-pushed the issue-18926-empty-class branch 3 times, most recently from d4f7cbf to 1924410 Compare February 26, 2026 10:25

Copilot AI review requested due to automatic review settings March 8, 2026 16:10

avadhutmali force-pushed the issue-18926-empty-class branch 2 times, most recently from a44749c to eb596fd Compare March 8, 2026 16:12

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Copilot started reviewing on behalf of avadhutmali March 8, 2026 16:17 View session

avadhutmali force-pushed the issue-18926-empty-class branch 3 times, most recently from 0ec45a5 to ff2a2e3 Compare March 8, 2026 16:31

avadhutmali force-pushed the issue-18926-empty-class branch 3 times, most recently from 8a8da07 to 47810b5 Compare March 10, 2026 07:07

romani requested changes Mar 10, 2026

View reviewed changes

Issue checkstyle#18926: Re-enable EmptyClass inspection

c0b6f6c

avadhutmali force-pushed the issue-18926-empty-class branch from 47810b5 to c0b6f6c Compare March 10, 2026 12:44

avadhutmali requested a review from romani March 10, 2026 12:48

romani approved these changes Mar 10, 2026

View reviewed changes

romani merged commit 68ef159 into checkstyle:master Mar 10, 2026
119 of 123 checks passed

Uh oh!

Conversation

avadhutmali commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avadhutmali commented Feb 25, 2026

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

romani Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

romani Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

avadhutmali Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

romani commented Feb 26, 2026

Uh oh!

romani commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

avadhutmali commented Mar 8, 2026

Uh oh!

romani commented Mar 9, 2026

Uh oh!

avadhutmali commented Mar 10, 2026

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

romani Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

avadhutmali commented Feb 25, 2026 •

edited

Loading

romani commented Mar 8, 2026 •

edited

Loading