Issue #18228: supressed indentation check#18944
Conversation
6edfc97 to
1a04838
Compare
|
@romani @mohitsatr please review this PR |
|
@romani please review |
|
@romani please review this PR |
|
@romani please review |
|
My concern is that this is Google's style issue, but fix is done in general implementation. @vivek-0509, please share your thoughts on this update |
2f42415 to
c912486
Compare
c912486 to
bfa7734
Compare
|
@vivek-0509 please review, I have changed the fix to only concern Google's style |
|
@romani i think this can be achieved through a SuppressionXpathSingleFilter in google_checks.xml instead. Lets try the SuppressionXpathSingleFilter approach if we can achieve this through that. |
|
@Anushreebasics You can close the PR the issue is resolved |
|
@Anushreebasics, please create issue on Indentation Check, with default confirmation . We need to detach your update from Google style. We can close this PR, for now. Code can be reused in new PR for new issue. |
fixes #18228
Root Cause: The [IndentationCheck] was checking line-wrapping indentation for all text block quotes, even when they legitimately appear at column 0 per Google style.
Solution: Modified the indentation check to suppress violations for text block quotes at column 0.