Issue #18486: Fix false positive in JavadocParagraph for tags#18814
Open
Shubhamyadav93 wants to merge 2 commits into
Open
Issue #18486: Fix false positive in JavadocParagraph for tags#18814Shubhamyadav93 wants to merge 2 commits into
Shubhamyadav93 wants to merge 2 commits into
Conversation
Member
|
Please read and watch videos at Starting_Development. |
Author
|
Hi @romani, thank you for the feedback and the resources. I am going through the 'Starting Development' guide now. I will check the failing CI tests locally and push the fixes soon to make the build green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a false positive in the
JavadocParagraphcheck where it incorrectly reported a violation for<p>tags that were preceded by an empty line but followed a block tag (such as@returnor@param).The fix ensures that the check correctly identifies the start of a new paragraph within block tags when the mandatory empty line is present.
Relation to existing issues
Fixes #18486
Observation for Reviewers
While working on this fix, a few changes related to pattern variables for Issue #10969 were included in this branch due to a local workspace overlap. I have kept the focus on #18486, but please let me know if you would like me to revert the unrelated changes or if they can stay as part of this PR.
Testing performed
Added regression test case in
JavadocParagraphCheckTest.javaCreated input file
InputJavadocParagraphLineBeforeAfterBlockTag.javawith the failing scenarioVerified that all tests pass locally using
mvn test