Skip to content

Issue #18748: Split openrewrite-recipes CI job into two parallel jobs#18762

Merged
romani merged 1 commit into
checkstyle:masterfrom
ayushactiveat:issue-18748-split-openrewrite
Jan 30, 2026
Merged

Issue #18748: Split openrewrite-recipes CI job into two parallel jobs#18762
romani merged 1 commit into
checkstyle:masterfrom
ayushactiveat:issue-18748-split-openrewrite

Conversation

@ayushactiveat

@ayushactiveat ayushactiveat commented Jan 25, 2026 •
edited by romani
Loading

Copy link
Copy Markdown
Contributor

Fixes #18748.
this PR splits the recipes into two parallel CircleCI jobs to cut the execution time effectively in half

  1. openrewrite-recipes-1: Runs 9 min
  2. openrewrite-recipes-2: Runs 12 min

@ayushactiveat ayushactiveat force-pushed the issue-18748-split-openrewrite branch 3 times, most recently from ff852a7 to 1d119d3 Compare January 25, 2026 23:52
@romani

romani commented Jan 26, 2026

Copy link
Copy Markdown
Member

No changes are expected.
We have configs of openrewrite we should reuse recipe list from such configs.

@ayushactiveat ayushactiveat force-pushed the issue-18748-split-openrewrite branch 4 times, most recently from 0f124ae to 2f137c6 Compare January 26, 2026 01:46
@ayushactiveat

ayushactiveat commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

@romani the jobs are now split and running in parallel, openrewrite-recipes-1 is executing in 5 minutes but it is failing because it found valid java 21 upgrades (changing SortedSet.first() to getFirst()).
since this PR is focused on the CI infrastructure, I have left the Java diffs untouched for now, let me know what do u think

@romani

romani commented Jan 27, 2026

Copy link
Copy Markdown
Member

Please create issue on this we will do activation of it separately.
Please disable this rule for now with comment above "until ...."

@ayushactiveat ayushactiveat mentioned this pull request Jan 29, 2026
Closed
@ayushactiveat ayushactiveat force-pushed the issue-18748-split-openrewrite branch from 2f137c6 to 5a9beb7 Compare January 29, 2026 07:57
@ayushactiveat ayushactiveat force-pushed the issue-18748-split-openrewrite branch from 5a9beb7 to 7c8d08c Compare January 29, 2026 08:28
@ayushactiveat

ayushactiveat commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@romani I've disabled UpgradeToJava21 and SequencedCollection and created issue #18789, let me know if you need any changes

romani
romani approved these changes Jan 30, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lets try this

@romani romani merged commit dd0b3d3 into checkstyle:master Jan 30, 2026
120 checks passed
@romani

romani commented Jan 30, 2026

Copy link
Copy Markdown
Member

@Pankraz76 should not have problems to run all at ones and CI will run it separately.

Pankraz76
Pankraz76 reviewed Jan 30, 2026
View reviewed changes
Comment thread config/rewrite.yml
- org.openrewrite.java.migrate.util.MigrateInflaterDeflaterToClose
- org.openrewrite.java.migrate.util.ReplaceStreamCollectWithToList
- org.openrewrite.java.migrate.util.SequencedCollection
# - org.openrewrite.java.migrate.util.SequencedCollection

@Pankraz76 Pankraz76 Jan 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this one without any comment? now every dev has to ask this question....

@romani romani Jan 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it, we will address it in #18789

@Pankraz76

Pankraz76 commented Jan 30, 2026

Copy link
Copy Markdown

because it found valid java 21 upgrades (changing SortedSet.first() to getFirst()).

yes had this myself...

its an rewrite issue it feels like caching because this stuff only comes with other changes as well.

We should just have applied the stuff and thats it.

I dont understand the big deal

@Pankraz76

Pankraz76 commented Jan 30, 2026

Copy link
Copy Markdown

@Pankraz76 should not have problems to run all at ones and CI will run it separately.

without release users can not run the recipes anyways so this statement is for sure wrong.

@romani

romani commented Jan 30, 2026

Copy link
Copy Markdown
Member

without release users can not run the recipes anyways so this statement is for sure wrong.

this is good reason to move it to separate job and run only by CI , not local.
and release is on me ... .

@Pankraz76

Pankraz76 commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown

yes only if you have no changes and this is not supposed 2 be, so no then users having go back and forth going crazy like hell.

CI (rewrite) has to work seamlessly everywhere not only somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

+1 more reviewer

@Pankraz76 Pankraz76 Pankraz76 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Split openrewrite-recipes in two groups to always run in CI in less that 15 minutes

3 participants

@ayushactiveat @romani @Pankraz76