Skip to content

Issue #7531: doc: added warning about AST changes with comment-aware checks#18675

Merged
romani merged 1 commit into
checkstyle:masterfrom
ayushactiveat:issue-7531-xpath-comment-doc
Jan 25, 2026
Merged

Issue #7531: doc: added warning about AST changes with comment-aware checks#18675
romani merged 1 commit into
checkstyle:masterfrom
ayushactiveat:issue-7531-xpath-comment-doc

Conversation

@ayushactiveat

@ayushactiveat ayushactiveat commented Jan 18, 2026

Copy link
Copy Markdown
Contributor

fixes #7531
this PR updates the documentation to warn users that enabling "comment-aware" checks (like TodoComment) changes the structure of the abstract syntax tree (AST) by inserting comment nodes.

Changes:
1 ) Command Line Usage (cmdline.xml.vm): Added a note in the "Generating XPath Suppressions XML" section.
2) Filters (suppressionxpathfilter.xml): Added an "Attention" note in the SuppressionXpathFilter documentation.

@romani

romani commented Jan 18, 2026

Copy link
Copy Markdown
Member

Please keep issue number as prefix

@romani

romani commented Jan 18, 2026

Copy link
Copy Markdown
Member

GitHub, generate website

@ayushactiveat ayushactiveat force-pushed the issue-7531-xpath-comment-doc branch from c887023 to eb5bb97 Compare January 18, 2026 02:29
@ayushactiveat

ayushactiveat commented Jan 18, 2026

Copy link
Copy Markdown
Contributor Author

@romani i have updated issue number as prefix , also the check PR description CI job is failing because Issue #7531 is missing the approved label , Could you please add it ?

@romani

romani commented Jan 18, 2026

Copy link
Copy Markdown
Member

GitHub, generate website

@ayushactiveat

Copy link
Copy Markdown
Contributor Author

Hi @romani, checking in to see if the generated docs look coorect to you.

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good !! thanks a lot

@romani romani merged commit fc5a45f into checkstyle:master Jan 25, 2026
119 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update doc to mention that XPath has direct connection to if comment aware checks are added or not

2 participants