Skip to content

Issue #18435: Fix XdocsExamplesAstConsistencyTest(arraytrailingcomma …#18472

Merged
romani merged 1 commit into
checkstyle:masterfrom
ZaheerAhmadDev:Fix-xdocs-Arraytrailingcomma
Jan 2, 2026
Merged

Issue #18435: Fix XdocsExamplesAstConsistencyTest(arraytrailingcomma …#18472
romani merged 1 commit into
checkstyle:masterfrom
ZaheerAhmadDev:Fix-xdocs-Arraytrailingcomma

Conversation

@ZaheerAhmadDev

@ZaheerAhmadDev ZaheerAhmadDev commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

Issue #18435 :
This PR removes ArrayTrailingComma Example 2 from the suppression list.

              The example no longer violates the `ArrayTrailingComma` check, so the suppression is unnecessary.

compared at https://www.diffchecker.com/text-compare/ :
image

@romani

romani commented Jan 2, 2026

Copy link
Copy Markdown
Member

single commit please
and if you make examples to be same, please remove them from suppression list.

@ZaheerAhmadDev ZaheerAhmadDev force-pushed the Fix-xdocs-Arraytrailingcomma branch from 65e505b to 4ef858b Compare January 2, 2026 03:56
@ZaheerAhmadDev

Copy link
Copy Markdown
Contributor Author

Thanks for the review
I’ve squashed the changes into a single commit.
And remove the ArrayTrailingComma Example 2 from the suppression list.
The example 2 was the same as the example 1.

@romani

romani commented Jan 2, 2026

Copy link
Copy Markdown
Member

GitHub, generate website

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good !!!

@romani romani merged commit a86af83 into checkstyle:master Jan 2, 2026
123 checks passed
@ZaheerAhmadDev ZaheerAhmadDev deleted the Fix-xdocs-Arraytrailingcomma branch January 3, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants