Issue #18118: fix indentation calculation logic for chained method call by M-SaaD-H · Pull Request #18406 · checkstyle/checkstyle

M-SaaD-H · 2025-12-23T12:42:21Z

Problem
The Indentation check incorrectly flagged the closing parenthesis in chained method calls like:

List.of("foo").stream()
    .findFirst()
    .ifPresentOrElse(
        System.out::println,
        () -> { throw new IllegalStateException(); }
    );  // False positive: expected level 8, but 12 is correct

However, using Stream.of("foo") instead produced no error, creating inconsistent behavior.

Solution
Modified MethodCallHandler.getIndentImpl() to add the line start column as an acceptable+ indent level for chained method calls. This allows correctly indented closing parens to be accepted while still validating actually incorrect indentation.

Atharv3221 · 2025-12-25T03:35:50Z

Github, generate report for Indentation/all-examples-in-one

Atharv3221 · 2025-12-25T03:38:45Z

@romani
This change fixes #17685

github-actions · 2025-12-25T04:40:31Z

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cc779ef4214d5a9492a71ccd48047b3b3e40d67b_2025043953/reports/diff/index.html

Atharv3221 · 2025-12-25T05:52:38Z

Diff is huge

M-SaaD-H · 2025-12-25T05:54:57Z

Hi @Atharv3221 ,
Thanks for pointing that out.
Yes, both these issues arise from the same underlying cause. I raised this PR against the original issue (18118). But it should also address the second issue (17685). Should I just mention this one in the description of this PR or the second issue needs to be addressed in a new PR?

Atharv3221 · 2025-12-25T06:00:28Z

As per regression report change has caused huge difference in reported violations. I don't think all violations change were false positives. Means fix wasn't proper. Please add a test case which fails from this change.

M-SaaD-H · 2025-12-25T09:35:40Z

Github, generate report for Indentation/all-examples-in-one

github-actions · 2025-12-25T10:41:06Z

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/17a959dcf706b8fabba0acaa4e28e040231a667e_2025104024/reports/diff/index.html

M-SaaD-H · 2025-12-25T17:42:42Z

Hi @Atharv3221
I have added the test for this fix and generated the report. Can you please look into it?
Let me know if you need anything from my side.

Atharv3221 · 2025-12-25T17:57:52Z

@M-SaaD-H
red one are the violation messages which were removed after the change and green one are added after change you can check the code its tested against by line number ahead.

M-SaaD-H · 2025-12-25T18:22:02Z

@Atharv3221
I reviewed the diff regression report for some of the projects. The added violations correspond to real cases in the affected files and are expected behavior for this check.

romani · 2025-12-30T18:37:51Z

rebased in web

romani · 2025-12-30T18:41:46Z

please add to inputs https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/17a959dcf706b8fabba0acaa4e28e040231a667e_2025104024/reports/diff/spring-framework/index.html#A13 looks like we missing this case in our Inputs

M-SaaD-H · 2026-01-02T09:10:34Z

@romani
Added the required inputs.

M-SaaD-H · 2026-01-06T16:09:35Z

@romani
The CI failure is due to a 403 while resolving org.sonatype.oss:oss-parent:9 from Maven Central in GitHub Actions. The same dependency resolves successfully locally, so this appears to be a CI/network issue. Could you please take a look?

M-SaaD-H · 2026-01-09T12:42:53Z

@romani
All CIs are passing now.

romani · 2026-01-10T06:58:20Z

Github, generate report for Indentation/all-examples-in-one

github-actions · 2026-01-10T10:22:02Z

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/71db1473effc3b6407ad310618fd5dc81ece3976_2026101626/reports/diff/index.html

M-SaaD-H · 2026-01-10T10:59:19Z

@romani
The failing CI is showing the following error. It is failing due to failure to parse the .ci/pitest-survival-check-xml.groovy file. I have seen some other PRs too, they shows the same warning, but this one fails due to GitHub actions timout (10min).

[WARNING] There were problems parsing .ci/pitest-survival-check-xml.groovy
[WARNING] org.openrewrite.groovy.GroovyParsingException: Failed to parse .ci/pitest-survival-check-xml.groovy at cursor position 11283. The surrounding characters in the original source are:
al Set result = new TreeSet<>(setOne)
result.removeIf { mutation -> setTwo.contains(mutation) }
return result
}

 /**
 * A class to represent the XML {@code mutation} node.
*/
@EqualsAndHashCode(excludes = ["lineNumber", "unstable"]~cursor~>)
@Immutable
class Mutation implements Comparable<Mutation> {

    /**
     * Mutation nodes present in suppressions file do not have a {@code lineNumber}.
     * The {@code lineNumber} is set to {@code -1} for such mutations.
     */
    private sta
  org.openrewrite.groovy.GroovyParserVisitor.visit(GroovyParserVisitor.java:209)

[INFO] Running recipe(s)...

Too long with no output (exceeded 10m0s): context deadline exceeded

romani · 2026-01-10T16:28:33Z

@M-SaaD-H , please review diff report, too much changes, we need to be sure that no regressions happening

romani · 2026-01-10T16:31:54Z

@vivek-0509, please help to review this PR. You are expert in this Check.

vivek-0509 · 2026-01-11T14:33:22Z

Sure, I’ll review it once I get back to my laptop.

vivek-0509 · 2026-01-14T08:09:24Z

Github, generate report for Indentation/all-examples-in-one

github-actions · 2026-01-14T09:01:45Z

Report generation failed. Please check the logs for more details.

Link: https://github.com/checkstyle/checkstyle/actions/runs/20986984251

vivek-0509 · 2026-01-14T10:25:43Z

Github, generate report for Indentation/all-examples-in-one

github-actions · 2026-01-14T12:06:29Z

Report for Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/47af876bed69675e8dc528ab2a87341522980fcb_2026112613/reports/diff/index.html

vivek-0509 · 2026-01-14T12:52:36Z

@romani
Ok to merge from my side, the suggested approach (#18406 (comment)) works as expected no regression caused.
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/47af876bed69675e8dc528ab2a87341522980fcb_2026112613/reports/diff/index.html

vivek-0509 · 2026-01-30T07:35:32Z

@M-SaaD-H We found a new surviving mutant please eliminate it

+  <mutation unstable="false">
+    <sourceFile>MethodCallHandler.java</sourceFile>
+    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.indentation.MethodCallHandler</mutatedClass>
+    <mutatedMethod>checkRparenIndent</mutatedMethod>
+    <mutator>org.pitest.mutationtest.engine.gregor.mutators.MathMutator</mutator>
+    <description>Replaced integer addition with subtraction</description>
+    <lineContent>if (rparenLevel != lparenLevel + 1</lineContent>
+  </mutation>

…calls

M-SaaD-H · 2026-01-30T08:45:36Z

@vivek-0509 @romani
Mutant eliminated.

romani

thanks a lot !!!

M-SaaD-H force-pushed the 18118 branch 3 times, most recently from a0ec879 to 17a959d Compare December 25, 2025 09:08

romani force-pushed the 18118 branch from 17a959d to 247f413 Compare December 30, 2025 18:37

M-SaaD-H force-pushed the 18118 branch 5 times, most recently from fbb84a3 to bfd4287 Compare January 2, 2026 08:49

M-SaaD-H force-pushed the 18118 branch 2 times, most recently from d57a852 to 50fb25a Compare January 7, 2026 15:22

romani force-pushed the 18118 branch from 50fb25a to 71db147 Compare January 10, 2026 06:57

vivek-0509 reviewed Jan 13, 2026

View reviewed changes

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/MethodCallHandler.java Outdated

M-SaaD-H closed this Jan 13, 2026

M-SaaD-H reopened this Jan 13, 2026

M-SaaD-H force-pushed the 18118 branch from 71db147 to 47af876 Compare January 13, 2026 16:05

M-SaaD-H requested a review from vivek-0509 January 13, 2026 17:41

vivek-0509 reviewed Jan 14, 2026

View reviewed changes

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/MethodCallHandler.java

M-SaaD-H force-pushed the 18118 branch from 47af876 to 82b180e Compare January 14, 2026 15:34

AryanKadam0007 mentioned this pull request Jan 19, 2026

Identation basicOffset force strict condition #17685

Open

romani force-pushed the 18118 branch from 82b180e to ea4110d Compare January 30, 2026 07:13

Issue checkstyle#18118: fix indentation calculation logic for method …

d0187f5

…calls

M-SaaD-H force-pushed the 18118 branch from ea4110d to d0187f5 Compare January 30, 2026 08:44

romani approved these changes Jan 30, 2026

View reviewed changes

romani merged commit ddc7211 into checkstyle:master Jan 30, 2026
119 checks passed

Uh oh!

Conversation

M-SaaD-H commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Atharv3221 commented Dec 25, 2025

Uh oh!

Atharv3221 commented Dec 25, 2025

Uh oh!

github-actions Bot commented Dec 25, 2025

Uh oh!

Atharv3221 commented Dec 25, 2025

Uh oh!

M-SaaD-H commented Dec 25, 2025

Uh oh!

Atharv3221 commented Dec 25, 2025

Uh oh!

M-SaaD-H commented Dec 25, 2025

Uh oh!

github-actions Bot commented Dec 25, 2025

Uh oh!

M-SaaD-H commented Dec 25, 2025

Uh oh!

Atharv3221 commented Dec 25, 2025

Uh oh!

M-SaaD-H commented Dec 25, 2025

Uh oh!

romani commented Dec 30, 2025

Uh oh!

romani commented Dec 30, 2025

Uh oh!

M-SaaD-H commented Jan 2, 2026

Uh oh!

M-SaaD-H commented Jan 6, 2026

Uh oh!

M-SaaD-H commented Jan 9, 2026

Uh oh!

romani commented Jan 10, 2026

Uh oh!

github-actions Bot commented Jan 10, 2026

Uh oh!

M-SaaD-H commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani commented Jan 10, 2026

Uh oh!

romani commented Jan 10, 2026

Uh oh!

vivek-0509 commented Jan 11, 2026

Uh oh!

Uh oh!

vivek-0509 commented Jan 14, 2026

Uh oh!

github-actions Bot commented Jan 14, 2026

Uh oh!

vivek-0509 commented Jan 14, 2026

Uh oh!

github-actions Bot commented Jan 14, 2026

Uh oh!

Uh oh!

vivek-0509 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vivek-0509 commented Jan 30, 2026

Uh oh!

M-SaaD-H commented Jan 30, 2026

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

M-SaaD-H commented Dec 23, 2025 •

edited

Loading

M-SaaD-H commented Jan 10, 2026 •

edited

Loading

vivek-0509 commented Jan 14, 2026 •

edited

Loading