Skip to content

Issue #9248: Re-enable regression testing for Configurate project#18301

Merged
romani merged 1 commit into
checkstyle:masterfrom
stoyanK7:9248
Dec 17, 2025
Merged

Issue #9248: Re-enable regression testing for Configurate project#18301
romani merged 1 commit into
checkstyle:masterfrom
stoyanK7:9248

Conversation

@stoyanK7

@stoyanK7 stoyanK7 commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

@stoyanK7

stoyanK7 commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator Author

There are 7 checkstyle violations that need to be resolved:

> Task :core:checkstyleMain 04:42
[ant:checkstyle] [ERROR] /home/semaphore/checkstyle/.ci-temp/Configurate/core/src/main/java/org/spongepowered/configurate/package-info.java:17: First sentence of Javadoc is missing an ending period. [SummaryJavadoc] 04:42
[ant:checkstyle] [ERROR] /home/semaphore/checkstyle/.ci-temp/Configurate/core/src/main/java/org/spongepowered/configurate/reactive/CachedPublisher.java:26: First sentence of Javadoc is missing an ending period. [SummaryJavadoc] 04:42
[ant:checkstyle] [ERROR] /home/semaphore/checkstyle/.ci-temp/Configurate/core/src/main/java/org/spongepowered/configurate/transformation/package-info.java:17: First sentence of Javadoc is missing an ending period. [SummaryJavadoc] 04:42
[ant:checkstyle] [ERROR] /home/semaphore/checkstyle/.ci-temp/Configurate/core/src/main/java/org/spongepowered/configurate/transformation/TransformAction.java:49: First sentence of Javadoc is missing an ending period. [SummaryJavadoc] 04:42
[ant:checkstyle] [ERROR] /home/semaphore/checkstyle/.ci-temp/Configurate/core/src/main/java/org/spongepowered/configurate/loader/package-info.java:17: First sentence of Javadoc is missing an ending period. [SummaryJavadoc] 04:42
[ant:checkstyle] [ERROR] /home/semaphore/checkstyle/.ci-temp/Configurate/core/src/main/java/org/spongepowered/configurate/serialize/Scalars.java:23: First sentence of Javadoc is missing an ending period. [SummaryJavadoc] 04:42
[ant:checkstyle] [ERROR] /home/semaphore/checkstyle/.ci-temp/Configurate/core/src/main/java/org/spongepowered/configurate/serialize/NumericSerializers.java:22: First sentence of Javadoc is missing an ending period. [SummaryJavadoc]

I guess I have to open a PR with https://github.com/SpongePowered/Configurate?

@stoyanK7

stoyanK7 commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator Author

Also, shouldn't this be named no-error-configurate or is there a reason for special no-violation-test- naming?

@romani

romani commented Dec 14, 2025

Copy link
Copy Markdown
Member

Yes, to them.
no-error-configurate - is good. To match what we have already as naming pattern.

no-violation-test- might more generic name, to means failure even on violations. I am ok with "no-error"

@stoyanK7 stoyanK7 mentioned this pull request Dec 16, 2025
Merged
@stoyanK7

stoyanK7 commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator Author

I opened PR SpongePowered/Configurate#617 with Configurate project. Shall we wait for the merge or just use my branch as we did with Kafka?

@romani

romani commented Dec 17, 2025

Copy link
Copy Markdown
Member

Thanks a lot.
Let's proceed with fork and branch usage.
It will start validate our functional changes sooner

@stoyanK7 stoyanK7 mentioned this pull request Dec 17, 2025
Closed
@stoyanK7

stoyanK7 commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator Author

no-error-configurate is successful:
https://checkstyle.semaphoreci.com/jobs/026ceaf6-81f5-43be-89ef-7a9cdd1d6c4e#L663

> Task :extra:extra-dfu2:checkstyleMain 03:52
> Task :extra:extra-dfu3:checkstyleMain 03:53
> Task :extra:extra-dfu4:checkstyleMain 03:53
> Task :extra:extra-dfu7:checkstyleMain 03:54
> Task :extra:extra-guice:checkstyleMain 03:54
> Task :extra:extra-kotlin:checkstyleMain NO-SOURCE 03:54
> Task :format:gson:checkstyleMain 03:54
> Task :format:hocon:checkstyleMain 03:55
> Task :format:jackson:checkstyleMain 03:55
> Task :format:xml:checkstyleMain 03:56
> Task :format:yaml:checkstyleMain 03:56
> Task :core:checkstyleTest 03:57
> Task :examples:checkstyleTest NO-SOURCE 03:57
> Task :tool:checkstyleTest NO-SOURCE 03:57
> Task :extra:extra-dfu2:checkstyleTest NO-SOURCE 03:57
> Task :core:checkstyleMain 03:57
> Task :extra:extra-dfu3:checkstyleTest 03:57
> Task :extra:extra-dfu7:checkstyleTest 03:57
> Task :extra:extra-dfu4:checkstyleTest 03:57
> Task :extra:extra-kotlin:checkstyleTest NO-SOURCE 03:57
> Task :extra:extra-guice:checkstyleTest 03:57
> Task :format:hocon:checkstyleTest 03:58
> Task :format:gson:checkstyleTest 03:58
> Task :format:xml:checkstyleTest 03:58
> Task :format:jackson:checkstyleTest 03:58
> Task :format:yaml:checkstyleTest
...
BUILD SUCCESSFUL in 2m 3s 03:58
30 actionable tasks: 30 executed

@stoyanK7 stoyanK7 marked this pull request as ready for review December 17, 2025 06:29
romani
romani approved these changes Dec 17, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good

@romani romani merged commit e9db837 into checkstyle:master Dec 17, 2025
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stoyanK7 @romani