Skip to content

Issue #18228: Suppress IndentationCheck if text-block quotes have 0 indentation#18243

Merged
romani merged 1 commit into
checkstyle:masterfrom
mohitsatr:suppress-0indent
Mar 19, 2026
Merged

Issue #18228: Suppress IndentationCheck if text-block quotes have 0 indentation#18243
romani merged 1 commit into
checkstyle:masterfrom
mohitsatr:suppress-0indent

Conversation

@mohitsatr

@mohitsatr mohitsatr commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@mohitsatr

mohitsatr commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

Github, generate report

@github-actions

github-actions Bot commented Dec 4, 2025 •
edited by romani
Loading

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/19916275518

[INFO] Generating "Checkstyle" report           --- maven-checkstyle-plugin:3.1.1:checkstyle
line 66:38 token recognition error at: '\'
line 27:22 token recognition error at: '\'
line 27:12 token recognition error at: '\'
Warning:  Unable to locate Source XRef to link to - DISABLED
Warning:  An issue has occurred with maven-checkstyle-plugin:3.1.1:checkstyle report, skipping LinkageError org/apache/maven/doxia/sink/SinkEventAttributeSet, please report an issue to Maven dev team.
java.lang.NoClassDefFoundError: org/apache/maven/doxia/sink/SinkEventAttributeSet
    at org.apache.maven.plugins.checkstyle.CheckstyleReportGenerator.doDetails (CheckstyleReportGenerator.java:602)
    at org.apache.maven.plugins.checkstyle.CheckstyleReportGenerator.generateReport (CheckstyleReportGenerator.java:152)
    at org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.generateMainReport (AbstractCheckstyleReport.java:780)
    at org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport (AbstractCheckstyleReport.java:537)
    at org.apache.maven.plugins.checkstyle.CheckstyleReport.executeReport (CheckstyleReport.java:57)
    at org.apache.maven.reporting.AbstractMavenReport.generate (AbstractMavenReport.java:255)

@romani

romani commented Dec 4, 2025

Copy link
Copy Markdown
Member

Github, generate report for configs in PR description

@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Report generation failed. Please check the logs for more details.

Link: https://github.com/checkstyle/checkstyle/actions/runs/19918503357

@mohitsatr

mohitsatr commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

Github, generate report

@github-actions

github-actions Bot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/20084821947

@mohitsatr

mohitsatr commented Dec 11, 2025

Copy link
Copy Markdown
Member Author

Github, generate report

@github-actions

github-actions Bot commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/20119239045

@romani

romani commented Dec 14, 2025

Copy link
Copy Markdown
Member

@mohitsatr , are you good here or need help ?

@mohitsatr

mohitsatr commented Jan 2, 2026

Copy link
Copy Markdown
Member Author

Github, generate report for configs in PR description

@github-actions

github-actions Bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/67c0b2d1e0a8288ef60f61d76d7f0eb86dd1a930_2026142232/reports/diff/index.html

@romani

romani commented Jan 4, 2026

Copy link
Copy Markdown
Member

Github, generate report for configs in PR description

@romani romani mentioned this pull request Jan 4, 2026
Merged
@romani

romani commented Jan 4, 2026

Copy link
Copy Markdown
Member

Github, generate report for configs in PR description

1 similar comment
@romani

romani commented Jan 4, 2026

Copy link
Copy Markdown
Member

Github, generate report for configs in PR description

@romani romani mentioned this pull request Jan 4, 2026
Merged
@romani

romani commented Jan 4, 2026

Copy link
Copy Markdown
Member

GitHub, generate report

@github-actions

github-actions Bot commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/67c0b2d1e0a8288ef60f61d76d7f0eb86dd1a930_2026164239/reports/diff/index.html

@github-actions

github-actions Bot commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/20696219741

@github-actions

github-actions Bot commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/67c0b2d1e0a8288ef60f61d76d7f0eb86dd1a930_2026192233/reports/diff/index.html

@github-actions

github-actions Bot commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/67c0b2d1e0a8288ef60f61d76d7f0eb86dd1a930_2026192353/reports/diff/index.html

romani
romani requested changes Jan 4, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

Comment thread src/main/resources/google_checks.xml
<module name="SuppressWithPlainTextCommentFilter">
<property name="checkFormat" value="IndentationCheck"/>
<property name="offCommentFormat" value='^""".?'/>
<property name="onCommentFormat" value='.'/>

@romani romani Jan 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation Check is under Treewalker, we can use Xpath, please use .

@mohitsatr mohitsatr Mar 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romani I just looked into Xpath, and found that we don't expose column no attribute in Xpath, so if there is no way to do something like
//TEXT_BLOCK_LITERAL_BEGIN[@column=0]
any other suggession??

@mohitsatr mohitsatr Mar 14, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @Zopsss

@romani romani Mar 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we always thought that if you have tree, why would you need to know column and skipped to add it to Xpath.

//TEXT_BLOCK_LITERAL_BEGIN[@column=0] is suppression for very special coding format.

@romani romani force-pushed the suppress-0indent branch from 67c0b2d to 49944a8 Compare March 15, 2026 22:17
@romani

romani commented Mar 15, 2026

Copy link
Copy Markdown
Member

all was green in CI, rebased in web ui.

@romani

romani commented Mar 15, 2026

Copy link
Copy Markdown
Member

GitHub, generate report

romani
romani approved these changes Mar 15, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good to merge this update !!!

@mohitsatr , thanks a lot !!

@github-actions

github-actions Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/49944a8_2026015524/reports/diff/index.html

Zopsss
Zopsss approved these changes Mar 19, 2026
View reviewed changes

@Zopsss Zopsss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, everything looks good to me

@romani romani merged commit 84514da into checkstyle:master Mar 19, 2026
118 checks passed
@mohitsatr mohitsatr deleted the suppress-0indent branch March 23, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

+1 more reviewer

@Zopsss Zopsss Zopsss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Zopsss Zopsss

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False-positive: Suppress indentation check when quotes start at the left margin

3 participants

@mohitsatr @romani @Zopsss