Skip to content

infra: do not run verify-no-exception-configs on master#18231

Merged
romani merged 1 commit into
checkstyle:masterfrom
stoyanK7:minor-no-master
Dec 2, 2025
Merged

infra: do not run verify-no-exception-configs on master#18231
romani merged 1 commit into
checkstyle:masterfrom
stoyanK7:minor-no-master

Conversation

@stoyanK7

@stoyanK7 stoyanK7 commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator

Resolves #7304 (comment)

better to avoid failures and simply skip execution on master branch

@stoyanK7

stoyanK7 commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator Author

Actionlint failure is unrelated (again):
https://github.com/checkstyle/checkstyle/actions/runs/19860246898/job/56908206373?pr=18231#step:4:4

 .github/workflows/diff-report.yml:59:13: condition "true" is always evaluated to true. remove the if: section [if-cond]
   |
59 |         if: 'true'
   |             ^~~~~~

@stoyanK7 stoyanK7 marked this pull request as ready for review December 2, 2025 13:29
@stoyanK7

stoyanK7 commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator Author

verify-no-exception-configs still runs for PRs - https://github.com/checkstyle/checkstyle/actions/runs/19860246949/job/56908206374?pr=18231

@stoyanK7 stoyanK7 mentioned this pull request Dec 2, 2025
Closed
romani
romani approved these changes Dec 2, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go !

@romani romani merged commit d1b57a0 into checkstyle:master Dec 2, 2025
90 of 124 checks passed
@stoyanK7 stoyanK7 deleted the minor-no-master branch December 2, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: verify-no-exception-configs should actually check contribution PR to append the same Check

2 participants

@stoyanK7 @romani