Issue #16621: Improve SuppressionSingleFilter examples#18125
Merged
romani merged 1 commit intoNov 20, 2025
Merged
Conversation
97c79bc to
0e79472
Compare
Member
|
single commit please, CI complains about merge commit. |
Member
|
please reference #16729 in PR and commit |
Member
|
GitHub, generate website |
romani
requested changes
Nov 18, 2025
| final String[] expectedWithFilter = {}; | ||
|
|
||
| verifyFilterWithInlineConfigParser(getPath("Example8.java"), | ||
| expectedWithoutFilter, expectedWithFilter); |
Member
There was a problem hiding this comment.
you need to remove Example8 from repo, as it become unused.
do same for other exampleX
Member
|
As you can see that web site did not change much, you need to update template file in xdoc folder for this module. |
4e8774a to
3987e80
Compare
Contributor
Author
|
i made all the changes you said only pr description check is failing |
Member
|
GitHub, generate website |
romani
requested changes
Nov 20, 2025
…emonstrate columns and id properties
3987e80 to
54d0f6f
Compare
Member
|
GitHub, generate website |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16729
Summary
This PR improves the SuppressionSingleFilter documentation examples by reducing redundancy and adding demonstrations of the
columnsandidproperties that were previously missing.Changes Made
columnsproperty example (Example 2): Demonstrates suppressing violations at specific column positionsidproperty example (Example 4): Demonstrates suppressing violations by module IDUpdated Examples Structure
linesproperty with ranges and multiple checkscolumnsproperty usage with NoWhitespaceAfter checkidproperty usage with MemberName checkFiles Changed
src/site/xdoc/filters/suppressionsinglefilter.xml- Updated documentationsrc/xdocs-examples/java/.../SuppressionSingleFilterExamplesTest.java- Updated test cases for 4 examplessrc/xdocs-examples/resources/.../Example2.java- Changed to show column filteringsrc/xdocs-examples/resources/.../Example4.java- Changed to show id filteringTesting