Skip to content

Issue #17956: Add sl4fj-api test dependency to properly configure the logger#17958

Merged
romani merged 1 commit into
checkstyle:masterfrom
mureinik:17956-slf4j-config-warning
Oct 20, 2025
Merged

Issue #17956: Add sl4fj-api test dependency to properly configure the logger#17958
romani merged 1 commit into
checkstyle:masterfrom
mureinik:17956-slf4j-config-warning

Conversation

@mureinik

@mureinik mureinik commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

Add the missing slf4j-api test dependency and align it to the slf4j-simple version so that the SLF4J logging in the test is properly configured.

This solves the following warning seen when running tests:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Fixes #17956

@mureinik

mureinik commented Oct 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The no-exception testing / no-exception-openjdk21 (pull_request)
no-exception testing / no-exception-openjdk21 (pull_request) CI check failed with the following error:

Error:  Failed to execute goal on project checkstyle: Could not resolve dependencies for project com.puppycrawl.tools:checkstyle:jar:12.1.0-SNAPSHOT
Error:  dependency: com.google.auto.value:auto-value-annotations:jar:1.11.0 (test)
Error:  	Could not transfer artifact com.google.auto.value:auto-value-annotations:jar:1.11.0 from/to central (https://repo.maven.apache.org/maven2): status code: 500, reason phrase: Internal Server Error (500)
Error:  -> [Help 1]

This looks like an ephemral error on the maven repo's side (HTTP-500 while trying to resolve an artifact that this PR did not change).
Is there any way to retrigger that test other than force pushing the origin branch, which will just retrigger the entire CI suite?

romani
romani approved these changes Oct 20, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@romani romani merged commit 6986e18 into checkstyle:master Oct 20, 2025
123 of 124 checks passed
@mureinik mureinik deleted the 17956-slf4j-config-warning branch October 20, 2025 20:40
@romani romani mentioned this pull request Nov 10, 2025
Closed
@mureinik mureinik mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SLF4J configuration warnings when running tests

2 participants

@mureinik @romani