Skip to content

Issue #17834: Fix DTD in suppressions.xml example#17838

Merged
romani merged 1 commit into
checkstyle:masterfrom
Hariom-kr:fix_suppression_dtd
Sep 27, 2025
Merged

Issue #17834: Fix DTD in suppressions.xml example#17838
romani merged 1 commit into
checkstyle:masterfrom
Hariom-kr:fix_suppression_dtd

Conversation

@Hariom-kr

@Hariom-kr Hariom-kr commented Sep 27, 2025

Copy link
Copy Markdown
Contributor

Fixes #17834

Updated

<!DOCTYPE suppressions PUBLIC
    "-//Checkstyle//DTD Checkstyle Configuration 1.2//EN"
    "https://checkstyle.org/dtds/suppressions_1_2.dtd">

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@romani romani merged commit 1c22f5b into checkstyle:master Sep 27, 2025
120 checks passed
@Hariom-kr

Copy link
Copy Markdown
Contributor Author

Thanks! On to the good third issue.

@Hariom-kr

Copy link
Copy Markdown
Contributor Author

@romani Please assign me a new problem to work on.

@romani

romani commented Sep 28, 2025

Copy link
Copy Markdown
Member

@Hariom-kr , thanks a lot for desire to help!

please look at https://github.com/checkstyle/checkstyle/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20second%20issue%22

I would recommend to do one update for #17128 and for #17449
and you can move to next level of good xxxxx issues

@Hariom-kr

Copy link
Copy Markdown
Contributor Author

okay, Thanks

@Hariom-kr Hariom-kr deleted the fix_suppression_dtd branch October 6, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix wrong dtd scheme reference in CLI example

2 participants