Issue 17825: Use correct DTD reference for suppression.xml file#17826
Merged
Conversation
Member
|
CI is not happy. keep only fist line in commit message, all other text is for PR or issue desctiptions. |
d309bd2 to
4b30957
Compare
4b30957 to
0b2608d
Compare
Contributor
Author
|
Apologies. Should be fixed now. |
romani
approved these changes
Sep 24, 2025
romani
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for detailed ticket and quick fix.
Will be released this weekend.
Do not hesitate to send more PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://checkstyle.sourceforge.io/filters/suppressionfilter.html#Description
When using the
--generate-checks-and-files-suppressionoption we were referencing the wrong DTD file in the generated xml (instead of the DTD file for the "suppressions" file https://checkstyle.org/dtds/suppressions_1_2.dtd we referenced the one for the configuration filehttps://checkstyle.org/dtds/configuration_1_3.dtd). This led to an invalid xml file, which couldn't be used for running checkstyle.
Now we use the correct DTD file everywhere.
Closes Issue: #17825