Skip to content

Issue #17487: Add JavaRecipeBestPractices#17806

Merged
romani merged 1 commit into
checkstyle:masterfrom
Pankraz76:JavaRecipeBestPractices
Sep 18, 2025
Merged

Issue #17487: Add JavaRecipeBestPractices#17806
romani merged 1 commit into
checkstyle:masterfrom
Pankraz76:JavaRecipeBestPractices

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Sep 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Issue #17487: Add JavaRecipeBestPractices

@Pankraz76 Pankraz76 marked this pull request as ready for review September 17, 2025 18:18
@Pankraz76

Pankraz76 commented Sep 17, 2025

Copy link
Copy Markdown
Author

Too long with no output (exceeded 10m0s): context deadline exceeded

@romani

romani commented Sep 18, 2025

Copy link
Copy Markdown
Member

Ok, let's try to split by profiles.

@Pankraz76

Pankraz76 commented Sep 18, 2025

Copy link
Copy Markdown
Author

actually rewrite completed, assuming flaky CI. We gonna have to split extend anyways so gonna figure it out the hard way.

[INFO] --- rewrite:6.17.0:run (checkstyle-autofix) @ checkstyle-openrewrite-recipes ---
[INFO] Using active recipe(s) [org.checkstyle.recipes.OpenRewriteRecipeBestPractices, org.checkstyle.recipes.JavaRecipeBestPractices, org.checkstyle.recipes.RecipeTestingBestPracticesSubset, CheckstyleAutoFixConfigured]
[INFO] Using active styles(s) []
[INFO] Validating active recipes...
[INFO] Project [checkstyle openrewrite recipes] Resolving Poms...
[INFO] Project [checkstyle openrewrite recipes] Parsing source files
[INFO] Running recipe(s)...
[INFO] 
[INFO] --- install:3.1.2:install (default-install) @ checkstyle-openrewrite-recipes ---
[INFO] Installing /tmp/checkstyle-openrewrite-recipes/pom.xml to /home/circleci/.m2/repository/com/puppycrawl/tools/checkstyle-openrewrite-recipes/1.0.0-SNAPSHOT/checkstyle-openrewrite-recipes-1.0.0-SNAPSHOT.pom
[INFO] Installing /tmp/checkstyle-openrewrite-recipes/target/checkstyle-openrewrite-recipes-1.0.0-SNAPSHOT.jar to /home/circleci/.m2/repository/com/puppycrawl/tools/checkstyle-openrewrite-recipes/1.0.0-SNAPSHOT/checkstyle-openrewrite-recipes-1.0.0-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:02 min
[INFO] Finished at: 2025-09-17T18:22:21Z
[INFO] ------------------------------------------------------------------------
Running Checkstyle validation to get report for openrewrite...
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules
[INFO] Installing Central Publishing features

Too long with no output (exceeded 10m0s): context deadline exceeded

@Pankraz76 Pankraz76 force-pushed the JavaRecipeBestPractices branch from 492618f to bd7d234 Compare September 18, 2025 08:15
romani
romani approved these changes Sep 18, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@romani romani merged commit dc128dd into checkstyle:master Sep 18, 2025
119 of 120 checks passed
@Pankraz76 Pankraz76 mentioned this pull request Sep 21, 2025
Merged
9 tasks
@Pankraz76 Pankraz76 mentioned this pull request Oct 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @romani