Issue #13626: Reused meta and xdoc functionality to gut annotation module javadocs#17675
Merged
Merged
Conversation
bc1e7ac to
d2c301e
Compare
romani
requested changes
Aug 26, 2025
d2c301e to
4436621
Compare
romani
requested changes
Aug 27, 2025
9f9f463 to
78403ba
Compare
romani
requested changes
Aug 29, 2025
SteLeo1602
commented
Aug 29, 2025
2d5c311 to
bf29208
Compare
romani
reviewed
Sep 4, 2025
| <td>Specify Xpath query.</td> | ||
| <td><a href="../../property_types.html#String">String</a></td> | ||
| <td><code>""</code></td> | ||
| <td><code></code></td> |
romani
reviewed
Sep 4, 2025
| <td>Set the JDK version that you are using. Old JDK version numbering is supported (e.g. 1.8 for Java 8) as well as just the major JDK version alone (e.g. 8) is supported. This property only considers features from officially released Java versions as supported. Features introduced in preview releases are not considered supported until they are included in a non-preview release.</td> | ||
| <td><a href="../../property_types.html#String">String</a></td> | ||
| <td><code>"22"</code></td> | ||
| <td><code>22</code></td> |
Member
|
lets limit updates to specific Modules or packages and lets make PR merge-able. |
4cc4676 to
a4f3688
Compare
Member
|
conceptually code changes are good, lets make CI green to merge this most basic version of code to allow us migrate step by step |
6 tasks
764f36c to
5f0d1b5
Compare
romani
requested changes
Sep 7, 2025
romani
left a comment
Member
There was a problem hiding this comment.
idea inspects need to be extended to allow new javadoc tag:
checkstyle/config/intellij-idea-inspections.xml
Line 2811 in df9f64c
items:
| <rule> | ||
| <element>CLASS</element> | ||
| <includes> | ||
| <include>com.puppycrawl.tools.checkstyle.meta.MetadataGeneratorUtil</include> |
Member
There was a problem hiding this comment.
~/java/github/romani/checkstyle [SteLeo1602/reuseMetadata L|✚ 1]
$ git diff
diff --git a/pom.xml b/pom.xml
index a248579e4c..d64e8281c5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -961,6 +961,7 @@
com.puppycrawl.tools.checkstyle.gui.TreeTableModelAdapter.UpdatingTreeModelListener
</exclude>
<!-- Metadata Generator related classes -->
+ <exclude>com.puppycrawl.tools.checkstyle.meta.MetadataGeneratorUtil</exclude>
<exclude>com.puppycrawl.tools.checkstyle.meta.ModuleDetails*</exclude>
<exclude>com.puppycrawl.tools.checkstyle.meta.JavadocMetadataScraper*</exclude>
<exclude>com.puppycrawl.tools.checkstyle.meta.XmlMeta*</exclude>
47aae39 to
5c7c6f8
Compare
5c7c6f8 to
f4acd61
Compare
romani
approved these changes
Sep 7, 2025
romani
left a comment
Member
There was a problem hiding this comment.
We will improve code later on, after migration is done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13626
Continuation of #13670
Additionally, changed Xdoc implementation to remove quotations around properties' default values