Skip to content

Issue #17171: Add 4.8.4.4 Switch expression section to coverage table#17459

Merged
romani merged 1 commit into
checkstyle:masterfrom
mohitsatr:4844-section
Jul 27, 2025
Merged

Issue #17171: Add 4.8.4.4 Switch expression section to coverage table#17459
romani merged 1 commit into
checkstyle:masterfrom
mohitsatr:4844-section

Conversation

@mohitsatr

Copy link
Copy Markdown
Member

resolves #17171

@romani

romani commented Jul 25, 2025

Copy link
Copy Markdown
Member

GitHub, generate website

@romani

romani commented Jul 25, 2025

Copy link
Copy Markdown
Member

looks like we keep extending our suppression list with such links, please do same to pass CI
recent example: 7765942#diff-8ebc4a79e7f2d18e09357cee57041175c404c841fe4c1cf970a9b6421b710e2cR105-R109

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

<a href="styleguides/google-java-style-20250426/javaguide.html#s4.8.4.4-switch-expressions">
4.8.4.4 Switch expressions</a>
</td>
<td>--</td>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.8.4.4

https://google.github.io/styleguide/javaguide.html#s4.8.4-switch

There are some words on how it should look, but not rules defined in what exactly they mean.
I am ok to mark it as no rules.

@romani romani requested a review from Zopsss July 25, 2025 19:40
@Zopsss

Zopsss commented Jul 26, 2025

Copy link
Copy Markdown
Member

@mohitsatr please reply to: #17171 (comment), after that I will review the PR. First we need to check if switch expressions are supported by us or not

@Zopsss Zopsss assigned romani and unassigned Zopsss Jul 27, 2025
@romani romani merged commit 56b12be into checkstyle:master Jul 27, 2025
118 checks passed
@mohitsatr mohitsatr deleted the 4844-section branch July 29, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google-style: add '4.8.4.4 Switch expressions' to coverage table

3 participants