Do I have to do anything about the javac17_standard test failing? That's kinda the purpose of noncompilable test sources?

We need to send fixes to Orekit project
https://checkstyle.semaphoreci.com/jobs/c3b3a06d-159d-4508-aed8-40876262544f
To see user reaction on new violations before release to whole world.

Ok, addressed those 2 points.

We need to send fixes to Orekit project checkstyle.semaphoreci.com/jobs/c3b3a06d-159d-4508-aed8-40876262544f To see user reaction on new violations before release to whole world.

The fixes aren't to anything new, it doesn't include the pattern variable def token by default, so the changes are just gonna be actual methods with method bodies on interfaces. Like this, and this.

I know, but we can not merge on red CI.
May be they have suppression that we can extend?

I guess I can also make a boolean option to skip interfaces

It is not good option.

It is easier to send PR to Orekit

Ok, PR created: https://gitlab.orekit.org/orekit/orekit/-/merge_requests/841

Ok, orekit updated. Should be good to go for another review.

Github, generate report for FinalParameters/all-examples-in-one

Report for FinalParameters/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4fd33196d8e2572ee0a9f2c119a4a78871900f8e_2025213820/reports/diff/index.html

Ok, looks like there's an issue with pattern variable def in for each, I'll check that.

EDIT: oh that was removed, and was never released as a non-preview feature. And it wasn't supported before, should it be now?

After fix please trigger regression diff testing as I did, it will speed up PR acceptance

This Check is aggressive by its nature.
But fact that we did not have complains before on missed violations might imply that world not not firm on where to put violations and where to skip.
This kind of reference to your idea to put property to skip in interfaces.

As you see diff is massive.

I don't think we should do such property now, but we should put in issue example how to bring behavior to previous state by suppression of violations under interfaces by https://checkstyle.org/filters/suppressionxpathsinglefilter.html#SuppressionXpathSingleFilter so users can simply copy paste config and not be blocked checkstyle upgrade by huge amount of violations. It might need few iterations for them to fix such violations. So suppression would be appreciated.

Github, generate report for FinalParameters/all-examples-in-one

Ok, suppression filter created: #17366 (comment)

Report for FinalParameters/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f3955655e0ea9b4f29e13e92af3836d5e2305bc7_2025232917/reports/diff/index.html

Ok, issue with java20 record pattern in foreach is fixed.

report is good.
Please do cosmetic changes requested above and we will proceed further.

Ok, changes addressed.

I'm unsure why the javac21 test is failing, that code seems to compile fine for me when I try it.

Ok, fixed it by updating image.

rebasing on latest master before merge