Skip to content

Issue #17309: Add resources-noncompilable to the compilation#17313

Merged
romani merged 1 commit into
checkstyle:masterfrom
mohitsatr:add-noncompiled-javac
Jul 4, 2025
Merged

Issue #17309: Add resources-noncompilable to the compilation#17313
romani merged 1 commit into
checkstyle:masterfrom
mohitsatr:add-noncompiled-javac

Conversation

@mohitsatr

@mohitsatr mohitsatr commented Jul 3, 2025

Copy link
Copy Markdown
Member

fixes #17309

@mohitsatr mohitsatr force-pushed the add-noncompiled-javac branch from c65faf0 to 02c727f Compare July 3, 2025 10:26
@mohitsatr

mohitsatr commented Jul 3, 2025

Copy link
Copy Markdown
Member Author

checkstyle/.ci/validation.sh

Line 549 in 02c727f

javac --release 17 --enable-preview -d target "${file}"

enable-preview is only available in javac 21 but the flag is turned on in every javac jobs. when try to run the workflow locally, it result in error.

$ ./.ci/validation.sh javac17
error: invalid source release 17 with --enable-preview
  (preview language features are only supported for release 21)

romani
romani requested changes Jul 3, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

Comment thread ...test/chapter4formatting/rule462horizontalwhitespace/InputFormattedWhitespaceAroundArrow.java Outdated
case String s -> {
switch (o2) {
case Integer newInt-> { // violation ''->' is not preceded with whitespace.'
case Integer nin when nin == 0-> { // violation ''->' is not preceded with whitespace.'

@romani romani Jul 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rename this variable nin to avoid spelling error.
You can use i

@mohitsatr mohitsatr Jul 4, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@mohitsatr mohitsatr force-pushed the add-noncompiled-javac branch from 02c727f to 1ef5be5 Compare July 4, 2025 03:27
romani
romani approved these changes Jul 4, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lo

@romani romani merged commit 3927608 into checkstyle:master Jul 4, 2025
119 checks passed
@mohitsatr mohitsatr deleted the add-noncompiled-javac branch July 4, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Google-style: Add resources-noncompilable inputs to the compilation by latest jdk

2 participants

@mohitsatr @romani