Skip to content

Issue #17295: Replaced <source> and supplemented <pre> tags#17297

Closed
SteLeo1602 wants to merge 1 commit into
checkstyle:masterfrom
SteLeo1602:removeSinceTags
Closed

Issue #17295: Replaced <source> and supplemented <pre> tags#17297
SteLeo1602 wants to merge 1 commit into
checkstyle:masterfrom
SteLeo1602:removeSinceTags

Conversation

@SteLeo1602

@SteLeo1602 SteLeo1602 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Issue: #17295

@romani

romani commented Jun 30, 2025

Copy link
Copy Markdown
Member

I did not get why since in title of PR

@SteLeo1602 SteLeo1602 changed the title Issue #17295: Replaced <since> and supplemented <pre> tags Issue #17295: Replaced <source> and supplemented <pre> tags Jun 30, 2025
@SteLeo1602

SteLeo1602 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

I did not get why since in title of PR

Sorry, I meant <source>. Now it is fixed

@SteLeo1602 SteLeo1602 mentioned this pull request Jun 30, 2025
Closed
@SteLeo1602

SteLeo1602 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

GitHub, generate website

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/annotation/annotationlocation.html#Description

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/annotation/missingdeprecated.html#Description

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/blocks/avoidnestedblocks.html#Description

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/coding/arraytrailingcomma.html#Description

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/coding/avoidinlineconditionals.html#Description

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/coding/covariantequals.html#Description

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/coding/declarationorder.html#Description

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/coding/hiddenfield.html#Notes

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/2600bda_20250701011353/checks/coding/illegaltype.html#Notes

romani
romani requested changes Jul 1, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recheck all

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheck.java
* </p>
* <pre>
* <div class="wrapper"><pre class="prettyprint"><code class="language-java">
* &#64;&#64; -32,4 +32,5 &#64;&#64; ForbidWildcardAsReturnTypeCheck.returnTypeClassNamesIgnoreRegex

@romani romani Jul 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a java file why class is '-java'?

@SteLeo1602 SteLeo1602 Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.java
* </p>
* <pre>
* <div class="wrapper"><pre class="prettyprint"><code class="language-java">
* &lt;!-- required till https://bugs.openjdk.org/browse/JDK-8160601 --&gt;

@romani romani Jul 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is xml language

@SteLeo1602 SteLeo1602 Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java Outdated
* Determines if ast is in the body of a flow control statement without
* braces. An example of such a statement would be
* <pre>
* <div class="wrapper"><pre class="prettyprint"><code class="language-java">

@romani romani Jul 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a class javadoc , why changed?

@SteLeo1602 SteLeo1602 Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SteLeo1602 SteLeo1602 closed this Jul 1, 2025
@SteLeo1602 SteLeo1602 deleted the removeSinceTags branch July 1, 2025 19:44
@SteLeo1602 SteLeo1602 restored the removeSinceTags branch July 1, 2025 19:44
@SteLeo1602 SteLeo1602 deleted the removeSinceTags branch July 1, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SteLeo1602 @romani