test:Add validation tests for filters in Xdocs and update PMD configu…#17248
Closed
Harsh-kumar-jha wants to merge 1 commit into
Closed
test:Add validation tests for filters in Xdocs and update PMD configu…#17248Harsh-kumar-jha wants to merge 1 commit into
Harsh-kumar-jha wants to merge 1 commit into
Conversation
romani
requested changes
Jun 22, 2025
romani
left a comment
Member
There was a problem hiding this comment.
thanks a lot !!!
item to improve:
| assertWithMessage("Filter description for " + filterName | ||
| + " in filters/index.xml should end with a period") | ||
| .that(description.charAt(description.length() - 1)) | ||
| .isEqualTo('.'); |
Member
There was a problem hiding this comment.
please make filter special imlementation of readSummaries() to do same assert as we do for Checks.
assertWithMessage("The summary for check " + checkName
+ " in the file \"" + path + "\""
+ " should match the summary"
+ " for this check in the file \"" + AVAILABLE_CHECKS_PATH + "\"")
.that(description)
.isEqualTo(summaries.get(checkName));
Member
|
Please read and watch videos at Starting_Development. there are video on how to make commit and how to investigate CI failures. |
Member
|
@Harsh-kumar-jha , please find time to finish PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made #17176
I found the filters exclusion logic in
XdocsPagesTest.javaline 375-376 and noticed it lacked explanation. Based on the code analysis:checks.xmlfiletestFiltersIndexPageTable()for filters validationTesting