Issue #17167: fp when switch is not wrapped#17229
Conversation
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
|
@0utplay, To build jar from this PR, please read #17135 (comment) Thanks s lot in advance |
|
The fix is not done, I still need to do some work. I'll do it ASAP |
|
Hi, just give me another ping and I will test it :) |
7aef136 to
02c5b3c
Compare
|
Github, generate report for Indentation/all-examples-in-one |
1 similar comment
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
|
Fix is ready for testing. |
|
@Aziz-755 , can you check behavior on trinodb We can add their codebase to our CI, no leak problems happening again, and no special reports required to trigger |
Hi, I just tried all of our previous failures. These are now fixed. I could not validate that no new issues arose as we are using the gradle checkstyle plugin. |
I have checked the behavior on the reported file and the false positives are gone. If testing checkstyle on the whole project is needed could you please share a guide how can I run checkstyle on a project ? ( I am only familiar with a single file 😅 ) |
02c5b3c to
c66310a
Compare
|
Example for other projects Version override looks like possible at |
|
I tested the changes on the TrinoDB project. I ran Checkstyle 10.25.0 (before the changes) and Checkstyle 10.25.1-SNAPSHOT-all (after the changes) using the following two commands: outputUsing-checkstyle-10.25.0-all.txt You can find the output files attached. All false positives related to this issue have been removed. I also noticed the presence of other violations related to |
fixes #17167