Skip to content

Issue #13538: Added documenation on no lombok support#16845

Merged
nrmancuso merged 1 commit into
checkstyle:masterfrom
Praveen7294:lombok
Apr 21, 2025
Merged

Issue #13538: Added documenation on no lombok support#16845
nrmancuso merged 1 commit into
checkstyle:masterfrom
Praveen7294:lombok

Conversation

@Praveen7294

@Praveen7294 Praveen7294 commented Apr 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #13538

Extends the documentation on no lombok support inside Limitations.
Added separate sub-section for it.

Build output

image

romani
romani requested changes Apr 13, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

Comment thread src/site/xdoc/writingchecks.xml Outdated
Comment thread src/site/xdoc/writingchecks.xml Outdated
@Praveen7294 Praveen7294 force-pushed the lombok branch 2 times, most recently from da03796 to 70f46eb Compare April 13, 2025 11:42
@Praveen7294 Praveen7294 requested a review from romani April 13, 2025 11:50
romani
romani requested changes Apr 14, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix:

Comment thread src/site/xdoc/writingchecks.xml Outdated
Comment thread src/site/xdoc/writingchecks.xml Outdated
@Praveen7294 Praveen7294 force-pushed the lombok branch 2 times, most recently from f690c42 to c802c60 Compare April 15, 2025 00:46
romani
romani approved these changes Apr 16, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last update:

Comment thread src/site/xdoc/writingchecks.xml Outdated
romani
romani requested changes Apr 16, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@Praveen7294 Praveen7294 force-pushed the lombok branch 2 times, most recently from 49771e8 to fa491e6 Compare April 16, 2025 14:50
@Praveen7294 Praveen7294 requested a review from romani April 16, 2025 18:00
romani
romani approved these changes Apr 16, 2025
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@romani

romani commented Apr 16, 2025

Copy link
Copy Markdown
Member

GitHub, generate website

1 similar comment
@romani

romani commented Apr 16, 2025

Copy link
Copy Markdown
Member

GitHub, generate website

@romani romani requested a review from nrmancuso April 16, 2025 22:16
@github-actions

github-actions Bot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fa491e6_20250416221827/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fa491e6_20250416221827/writingchecks.html#Limitations

@github-actions

github-actions Bot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fa491e6_20250416222201/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/fa491e6_20250416222201/writingchecks.html#Limitations

Pankraz76
Pankraz76 suggested changes Apr 20, 2025
View reviewed changes

@Pankraz76 Pankraz76 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling (capital letters at the beginning of sentences)

Comment thread src/site/xdoc/writingchecks.xml Outdated
Comment thread src/site/xdoc/writingchecks.xml Outdated
@Praveen7294 Praveen7294 force-pushed the lombok branch 2 times, most recently from 7af98eb to d2d28df Compare April 20, 2025 13:28
nrmancuso
nrmancuso suggested changes Apr 21, 2025
View reviewed changes

@nrmancuso nrmancuso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item:

Comment thread src/site/xdoc/writingchecks.xml Outdated
nrmancuso
nrmancuso approved these changes Apr 21, 2025
View reviewed changes

@nrmancuso nrmancuso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update, we get a lot of questions about this topic!

@nrmancuso

nrmancuso commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

Ok to merge once CI is green.

@Praveen7294

Praveen7294 commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

welcome :)

@nrmancuso nrmancuso merged commit def1e34 into checkstyle:master Apr 21, 2025
@nrmancuso nrmancuso mentioned this pull request Apr 21, 2025
Closed
@Praveen7294 Praveen7294 deleted the lombok branch April 23, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

+2 more reviewers

@Pankraz76 Pankraz76 Pankraz76 requested changes

@nrmancuso nrmancuso nrmancuso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nrmancuso nrmancuso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend documentation on no lombok support

4 participants

@Praveen7294 @romani @nrmancuso @Pankraz76