Skip to content

Issue #16360: Migrate XMLLoggerTest.testAddErrorOnZeroColumns to use inlineConfigParser #16701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romani merged 1 commit into from
Apr 2, 2025
Merged

Issue #16360: Migrate XMLLoggerTest.testAddErrorOnZeroColumns to use inlineConfigParser #16701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/test/java/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,19 +232,8 @@ public void testAddErrorWithEncodedMessage() throws Exception {

@Test
public void testAddErrorOnZeroColumns() throws Exception {
final XMLLogger logger = new XMLLogger(outStream, OutputStreamOptions.CLOSE);
logger.auditStarted(null);
final Violation violation =
new Violation(1, 0,
"messages.properties", "key", null, SeverityLevel.ERROR, null,
getClass(), null);
final AuditEvent ev = new AuditEvent(this, "Test.java", violation);
logger.fileStarted(ev);
logger.addError(ev);
logger.fileFinished(ev);
logger.auditFinished(null);
verifyXml(getPath("ExpectedXMLLoggerErrorZeroColumn.xml"), outStream,
violation.getViolation());
verifyWithInlineConfigParserAndXmlLogger("InputXMLLoggerErrorOnZeroColumn.java",
"ExpectedXMLLoggerErrorZeroColumn.xml");
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions .../resources/com/puppycrawl/tools/checkstyle/xmllogger/ExpectedXMLLoggerErrorZeroColumn.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<checkstyle version="">
<file name="Test.java">
<error line="1" severity="error" message="$0" source="com.puppycrawl.tools.checkstyle.XMLLoggerTest"/>
<file name="InputXMLLoggerErrorOnZeroColumn.java">
<error line="14" severity="error" message="Javadoc line should start with leading asterisk." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMissingLeadingAsteriskCheck"/>
</file>
</checkstyle>
21 changes: 21 additions & 0 deletions .../resources/com/puppycrawl/tools/checkstyle/xmllogger/InputXMLLoggerErrorOnZeroColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/*xml
<module name="Checker">
<module name="TreeWalker">
<module
name="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMissingLeadingAsteriskCheck">
</module>
</module>
</module>
*/

package com.puppycrawl.tools.checkstyle.xmllogger;

/**
Test for {@link com.puppycrawl.tools.checkstyle.xmllogger} when
* the column number is 0.
* <p>
* The test is to ensure that the column number is set to 0 in the XML output.
* </p>
*/
public class InputXMLLoggerErrorOnZeroColumn {
}