@romani
I'm stuck with an xpathRegression failure. Could you take a look and let me know if I'm missing something?

unexpected output: C:\Users\anmol\IdeaProjects\checkstyle3\src\it\resources\
org\checkstyle\suppressionxpathfilter\unnecessarynullwithinstanceof\
InputXpathUnnecessaryNullCheckWithInstanceOf.java:5:13: Unnecessary nullity check with instanceof operator.
expected: 0
but was : 1
Expected :0
Actual   :1
<Click to see difference>

The Xpath test is failing, do i need to configure something related to the new check .

It seems like the XPath query isn't suppressing the violation, causing it to be flagged at:

verify(treeWalkerConfigWithXpath, fileToProcess.getPath(), CommonUtil.EMPTY_STRING_ARRAY);

please have a look.

@romani all CI is green, please review
please help me with how to mention violations in message.properties for languages that are not supported !
like for ja, zh

@romani all CI is green, please review please help me with how to mention violations in message.properties for languages that are not supported ! like for ja, zh

Just use google, we do not have any maintainers that can read or write these

Just use google, we do not have any maintainers that can read or write these

thanks @nrmancuso
the issue was actually that IDEA was supporting these languages but no issue, i configured the file encoding to UTF-8.

@mahfouz72 , as this is your issue please be welcome to review first.

@Anmol202005 , please read on how to do regression testing for new modules
https://github.com/checkstyle/checkstyle/tree/master/.github/workflows#diff-report-by-configuration-in-pull-request-description

we need report of how it works in wild reallife code.

github, generate site

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f324a11_20250320212651/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f324a11_20250320212651/checks.html#

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f324a11_20250320212651/checks/coding/index.html#

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f324a11_20250320212651/checks/coding/unnecessarynullcheckwithinstanceof.html#

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/e99d147_2025070400/reports/diff/index.html

GitHub, generate website

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/0b80604_20250518173003/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/0b80604_20250518173003/checks.html#Standard_Checks

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/0b80604_20250518173003/checks/coding/index.html#Coding_Checks

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/0b80604_20250518173003/checks/coding/unnecessarynullcheckwithinstanceof.html#

based on #16489 (comment)

please send PRs to following projects (you can send updates to any other projects too):
Orekit
camunda

to prove that people are welcoming such updates, and validations is correct. and eventual auto-fix will be well welcomed also.