Skip to content

Issue #13213: Remove '//ok' from Input Files(parenpad)#16413

Merged
romani merged 1 commit intocheckstyle:masterfrom
vishakha-mali:parenPad2
Feb 23, 2025
Merged

Issue #13213: Remove '//ok' from Input Files(parenpad)#16413
romani merged 1 commit intocheckstyle:masterfrom
vishakha-mali:parenPad2

Conversation

@vishakha-mali
Copy link
Copy Markdown
Contributor

@vishakha-mali vishakha-mali commented Feb 23, 2025 •
edited by romani
Loading

Fixes #13213

Removed 56 //ok from parenpad module from Input files

InputParenPadCheckEmoji.java -> 2
InputParenPadForEnum.java -> 2
InputParenPadLambda.java -> 2
InputParenPadLambdaOnly.java -> 4
InputParenPadLambdaOnlyWithSpace.java -> 4
InputParenPadLambdaWithSpace.java -> 3
InputParenPadLeftRightAndNoSpace3.java -> 1
InputParenPadNoStackoverflowError.java -> 2
InputParenPadToCheckTrimFunctionInOptionProperty.java -> 2
InputParenPadTryWithResources.java -> 4
InputParenPadTryWithResourcesAndSuppression.java -> 4
InputParenPadWhitespace.java -> 5
InputParenPadWhitespace2.java -> 5
InputParenPadWithDisabledLambda.java -> 7
InputParenPadWithSpace.java -> 1
InputParenPadWithSpaceAndDisabledLambda.java -> 8

PROOF:

DELL@DESKTOP-KL8FGN8 MINGW64 ~/checkstyle (master)
$ grep parenpad config/checkstyle-input-suppressions.xml
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadCheckEmoji.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadCheckEmoji.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadForEnum.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadForEnum.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaOnly.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaOnly.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaOnly.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaOnly.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaOnlyWithSpace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaOnlyWithSpace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaOnlyWithSpace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaOnlyWithSpace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaWithSpace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaWithSpace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLambdaWithSpace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadLeftRightAndNoSpace3.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadNoStackoverflowError.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadNoStackoverflowError.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadToCheckTrimFunctionInOptionProperty.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadToCheckTrimFunctionInOptionProperty.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadTryWithResources.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadTryWithResources.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadTryWithResources.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadTryWithResources.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadTryWithResourcesAndSuppression.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadTryWithResourcesAndSuppression.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadTryWithResourcesAndSuppression.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadTryWithResourcesAndSuppression.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace2.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace2.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace2.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace2.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWhitespace2.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpace.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpaceAndDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpaceAndDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpaceAndDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpaceAndDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpaceAndDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpaceAndDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpaceAndDisabledLambda.java"/>
            files="checks[\\/]whitespace[\\/]parenpad[\\/]InputParenPadWithSpaceAndDisabledLambda.java"/>

DELL@DESKTOP-KL8FGN8 MINGW64 ~/checkstyle (parenPad)
$ grep parenpad config/checkstyle-input-suppressions.xml

DELL@DESKTOP-KL8FGN8 MINGW64 ~/checkstyle (parenPad)
$ echo $?
1

@vishakha-mali
Copy link
Copy Markdown
Contributor Author

vishakha-mali commented Feb 23, 2025

@romani Kindly Review.

romani
romani approved these changes Feb 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@romani romani merged commit 6e0a0bf into checkstyle:master Feb 23, 2025
101 of 102 checks passed
@vishakha-mali
Copy link
Copy Markdown
Contributor Author

vishakha-mali commented Feb 24, 2025

@romani do I have to raise issue??

@romani
Copy link
Copy Markdown
Member

romani commented Feb 24, 2025

Nothing is required, we are all good. Thanks a lot.

@vishakha-mali vishakha-mali deleted the parenPad2 branch February 24, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove '//ok' comments from Input files

2 participants

@vishakha-mali @romani