Issue #15967: fix yield fails indentation in switch with forceStrictCondition#16131
Conversation
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
3e7d572 to
cd71ef5
Compare
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
cd71ef5 to
62e609c
Compare
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
62e609c to
d013287
Compare
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
d013287 to
64352f4
Compare
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
|
Github, generate report for Indentation/Example2 |
|
@romani please check out regression report #16131 (comment) basically it resolves the original problem for which issue is raised. there is just one false positive case other report : #16131 (comment) ps: please ignore diff reports which are not linked in this comment |
64352f4 to
df5c745
Compare
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
df5c745 to
2788f16
Compare
romani
left a comment
There was a problem hiding this comment.
good to merge !!
thanks a lot !
|
@romani please reply to comment at #16131 (comment) @mohitsatr please rebase on the latest master branch |
|
yes, lets create separate issue on this case, we can improve lateron on this. |
…trictCondition fix
2788f16 to
7c25b3b
Compare
That case existed even before the new changes. With these changes, we’ve just replaced one incorrect message with another. We can leave it as it is for now. If anyone encounters a problem, they can raise the issue. what do you think ? |
|
I am ok to not create issue , we have already a lot on this Check. And we had bad calculation of expected intendtation and after this update it becomes even more bad, but for user main problem is violation existence, not message. |
|
Github, generate report for Indentation/all-examples-in-one |
|
Report for Indentation/all-examples-in-one: |
fixes #15967