dependency: bump org.apache.maven.plugins:maven-site-plugin from 3.12.1 to 3.21.0#15799
Closed
dependabot[bot] wants to merge 4 commits into
Closed
Conversation
428cb7a to
3a4eb11
Compare
Member
|
Member
|
@michael-o , do you know how to define skin for new maven plugin ? I tried: but this does not work. |
Contributor
You need to define it in your |
3a4eb11 to
138106d
Compare
Member
|
thanks a lot. workaround for bulid problem is: but web site is broken and looks like needs more more tuning. |
Member
|
GitHub, generate website Failure: https://github.com/checkstyle/checkstyle/actions/runs/11685772341/job/32540847864#step:3:60 |
138106d to
7b69b5d
Compare
Member
|
GitHub, generate website |
7b69b5d to
aef7b48
Compare
Member
|
GitHub, generate website |
Contributor
|
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/aef7b48_2024234815/index.html |
michael-o
suggested changes
Nov 22, 2024
| <skin> | ||
| <groupId>org.apache.maven.skins</groupId> | ||
| <artifactId>maven-fluido-skin</artifactId> | ||
| <version>2.0.0-M11</version> |
Member
There was a problem hiding this comment.
@michael-o , I tried to use GA, but still the same result: no site pages are generated, only main index.html with empty content. see all details bellow.
in debug logs, there is nothing obviously suspicious.
@michael-o , do know what can cause this ?
aef7b48 to
1b69582
Compare
Member
|
I did migration to new schema by hint from https://www.mail-archive.com/users@maven.apache.org/msg145112.html site still not generates empty page for index and no other pages at all. log of execution - https://gist.github.com/romani/305a71941fa09de3212e606b1d6a2eeb log of execution on master - https://gist.github.com/romani/8ab7cecf8295f151de138d16567919d0 |
Member
|
looks like I am not alone https://issues.apache.org/jira/browse/MSITE-1026, looks like we should upgrade doxia to 2.x first. |
Member
|
by diff of debug logs I found: bunch (about 20) of |
Member
|
I removed doxia usage completely from project: but result is same: pages are not generated: so something else is required by site plugin. |
Member
|
interesting comments: but usage of it does not help, same problem: looks like parent pom of apache reverted web site to old version to due to some problem: apache/commons-parent@ac4be53 and it was bumbed automatically by dependabot - apache/commons-parent@d9cca74 same as in our case. |
Contributor
|
I'll try ti check this next couple of days |
Contributor
|
Looking into now... |
Contributor
|
Migrating to Doxia 2.0.0 is not related to the site generation of this plugin, they are disjoint. Here is your problem: and |
Member
|
Thanks a lot!!! |
Member
https://maven.apache.org/plugins-archives/maven-site-plugin-3.6/run-mojo.html#xdocDirectory
removal of xdocDirectory usage and removal of custom Javascripts are both MUST updates. |
c4705d4 to
f00e935
Compare
Member
|
GitHub, generate website |
Member
|
This PR too prone to conflicts, I will move xdoc folder in quick separate PR. |
18 tasks
Member
|
@michael-o , I still see at web site that custom CSS files are possible. but in scope of this PR we saw that it is not actually working for some reason ... I hope "embedding of custom js files" is still supported, and we just need to update them(js files) to work with new website sturture, right ? |
Contributor
Either of your resources is breaking your rendering. I recommend to start from zero or reduce piece by piece. |
Member
|
That a lot, I treat it as Yes and Yes |
2a1d245 to
a8af51c
Compare
Member
|
@Zopsss , this PR is ready for CSS rewrite and fix for javascript files to continue to work with new skin. xdoc moved in scope of: #16078 xml plugin is disabled due to problems: https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html |
Merged
Member
|
GitHub, generate website |
Contributor
|
@romani This looks much much better now. |
5aa3cd9 to
0c647d4
Compare
rnveach
suggested changes
Jan 5, 2025
Comment on lines
-48
to
-51
| <script type="text/javascript" src="$relativePath/js/checkstyle.js"></script> | ||
| <script type="text/javascript" | ||
| src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.3/jquery.min.js"></script> | ||
| <script type="text/javascript" src="$relativePath/js/anchors.js"></script> |
Contributor
There was a problem hiding this comment.
This has to be fixed before merge otherwise website is broken.
Member
There was a problem hiding this comment.
If we keep these JS files then our site gets broken. Here is a screenshot of how site looks if we keep these JS files.
CSS is also broken currently. I'm working on both of this, trying to fix them. Once I will have some useful changes I will send a PR for review.
Member
|
I have sent a follow up PR with all the changes made here. #16126 Fixing broken JS & CSS will happen there. |
Member
|
Initial update is done at #16126 There bunch of minor defects, all of the referenced in special issue. @michael-o , thanks a lot for your help, without your help it will be very complicated to upgrade. |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Contributor
Happy to help! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16077
Bumps org.apache.maven.plugins:maven-site-plugin from 3.12.1 to 3.21.0.
Release notes
Sourced from org.apache.maven.plugins:maven-site-plugin's releases.
Commits
43f73ec[maven-release-plugin] prepare release maven-site-plugin-3.21.0a2880fb[MSITE-1024] Remove IT for MSITE-9016171e7d[MSITE-1023] Upgrade plugins and components (in ITs)efd8a57[MSITE-1022] Upgrade to Maven Reporting Exec 2.0.0f5c5fc9Fix typos in history.apt and faq.fml64c4035[MSITE-1021] Bump doxiaSitetoolsVersion from 2.0.0-M19 to 2.0.0e26765c[MSITE-1020] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M...354cf19[MSITE-1019] Bump doxiaVersion from 2.0.0-M12 to 2.0.067b568aUse '@project.' instead of '@pom.' expression prefixfdfd807Add version 3.20.0 to plugin historyYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)