Issue #15003: Add new input file for pattern syntax in UnnecessaryPar…#15250
Merged
Conversation
…cessaryParenthesesCheck
mahfouz72
commented
Jul 13, 2024
Comment on lines
21
to
+29
| boolean result = (o instanceof String a) ? | ||
| (o instanceof String x) : (!(o instanceof String y)); | ||
|
|
||
| boolean f = (o instanceof String x); | ||
| // violation above, 'Unnecessary parentheses around assignment right-hand side.' | ||
|
|
||
| boolean b = (!(o instanceof Rectangle(_, _))); | ||
| // violation above, 'Unnecessary parentheses around assignment right-hand side.' | ||
| boolean c = !(o instanceof Rectangle(_, _)); |
Member
Author
There was a problem hiding this comment.
Given these new examples, shouldn't we have 2 violations on line 22 ?
Contributor
There was a problem hiding this comment.
Yes, please open an issue for us to explore this more
nrmancuso
approved these changes
Jul 13, 2024
nrmancuso
left a comment
Contributor
There was a problem hiding this comment.
Ok to merge after we create an issue for https://github.com/checkstyle/checkstyle/pull/15250/files#r1676837498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15003